Update email claim example to use list of claim values#6326
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Muhammad Hamza Zaib <[email protected]>
| { | ||
| "sub": ["alice", "bob" ], | ||
| "email": "[email protected]", | ||
| "email": ["[email protected]"], |
There was a problem hiding this comment.
Are you assuming this is a mistake in the docs? Or did you try this and it didn't work?
I don't have the code in front of me at the moment, but I am about 99% certain that all claims can be mapped to a list of string values or a scalar string value.
There was a problem hiding this comment.
I agree that in both those locations, the description is narrower than what is supported in reality. I would welcome those being amended appropriately.
As to the change that's already proposed by this PR, as long as those overly narrow descriptions cited above are corrected, I think there would be a small benefit to leaving the example as it had been previously, since it demonstrates a broader range of supported options.
All pull requests must reference an existing issue with no blocking labels.
PRs that do not meet this requirement will be automatically closed. See the
Contributor Guide for details.
Issue Reference
Closes #6325
Description
Fix example for service account claim annotation
Checklist
kind/proposal,needs discussion,needs research,maintainer only,area/security,size/large,size/x-large,size/xx-large).AI Use Disclosure
Select one:
Sign-Off
git commit -s) (required)git commit -S) (encouraged)