Fix pydantic example to include arbitrary_types_allowed config#1627
Open
veeceey wants to merge 5 commits intoaio-libs:masterfrom
Open
Fix pydantic example to include arbitrary_types_allowed config#1627veeceey wants to merge 5 commits intoaio-libs:masterfrom
veeceey wants to merge 5 commits intoaio-libs:masterfrom
Conversation
…ibs#1624) The pydantic usage example was missing the required `model_config = ConfigDict(arbitrary_types_allowed=True)` setting, causing a PydanticSchemaGenerationError when users followed the docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1627 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 30 30
Lines 5940 5940
Branches 282 282
=======================================
Hits 5903 5903
Misses 22 22
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The lint CI was failing because the GitHub Actions runner had stale package indices, causing 404 errors when fetching glib2.0 dependencies of libenchant-2-dev. Adding apt-get update refreshes the package lists before the install. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove trailing underscore from `pydantic_` in the changelog fragment to avoid an RST "Unknown target name" error during the sphinx doc-spelling lint step, since the `_pydantic` hyperlink target is only defined in docs/index.rst. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
The Windows CI failure on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_config = ConfigDict(arbitrary_types_allowed=True)setting, causing aPydanticSchemaGenerationErrorwhen users followed the example verbatimConfigDictand setarbitrary_types_allowed=True, and adjusted the prose to mention this requirementWhat changed
docs/index.rst: Updated the pydantic example to include:CHANGES/1624.doc.rst: Added a towncrier changelog fragment for this documentation fix.Test plan
pydantic>=2.0and current yarl