Parameterize test_simple_web_file_response benchmarks by file size#12913
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12913 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 131 131
Lines 47824 47834 +10
Branches 2480 2480
=======================================
+ Hits 47324 47334 +10
Misses 376 376
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
…s will hopefuly fix tests on windows
for more information, see https://pre-commit.ci
Merging this PR will not alter performance
Performance Changes
Comparing Footnotes
|
Backport to 3.15: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c2f4ac4 on top of patchback/backports/3.15/c2f4ac4037753c4762dbf5e4e77a09adcd6932d7/pr-12913 Backporting merged PR #12913 into master
🤖 @patchback |
|
I'll do a backport to 3.15 |
|
Backport to 3.15: #12926 |
…e_response benchmarks by file size (#12926)
What do these changes do?
Parameterize test_simple_web_file_response and test_simple_web_file_response_fallback by small (10 kb) and large (1 MB) file sizes. This establishes a baseline and let us see how much enabling KTLS impacts performance depending on the file size in the aiofastnet PR
Are there changes in behavior for the user?
No
Is it a substantial burden for the maintainers to support this?
No
Related issue number
Checklist
CHANGES/folder