fix: replace pkg_resources in system parameter logging - #3417
Open
mohamed-chaaben wants to merge 1 commit into
Open
fix: replace pkg_resources in system parameter logging#3417mohamed-chaaben wants to merge 1 commit into
mohamed-chaaben wants to merge 1 commit into
Conversation
Collect installed package versions with importlib.metadata and use the importlib-metadata backport on Python 3.7. Preserve legacy package-name normalization, cache the distribution scan, and return copies so callers cannot modify cached data. Add regression coverage.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg_resources.working_setwithimportlib.metadataimportlib-metadatabackport on Python 3.7Motivation
get_installed_packages()is used whenlog_system_params=True. Its current use of the deprecatedpkg_resourcesmodule can fail when that module is not available.Testing
ruff check aim/ext/utils.py setup.py tests/ext/test_utils.pyruff format aim/ext/utils.py setup.py tests/ext/test_utils.py --checkpytest tests/ext/test_utils.py tests/sdk/test_run_creation_checks.py -vResult: 3 tests passed. The reported SQLAlchemy warnings are pre-existing and unrelated to this change.