Fix band example after CP2K FFT keyword removal - #233
Open
DCM-Uni-Paderborn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CP2K dashboard's AiiDA test fails in
example_bandswithKeyError: 'output_bands'. The underlying calculation aborts because CP2K removedGLOBAL/EXTENDED_FFT_LENGTHSin cp2k/cp2k#5868.Remove the obsolete keyword and its otherwise empty
GLOBALblock from the example. No calculation parameters, reference values, tolerances, or result checks are otherwise changed.Validation:
dd0921c.Validation covers the affected end-to-end example, not the full AiiDA test suite.
CI maintenance (follow-up commit
901ac59):actions/cache@v2withv6; the plugin jobs previously failed during setup, before any tests ran.v3.21.2, fixing itstokenize.cookie_recrash under Python 3.14. No hooks are skipped.Follow-up validation:
makebuild passes and all four references produce external links.