Skip to content

🐛 workflow: Fix bugs in SuperConWorkChain and update convergence protocol#25

Open
ymzhang0 wants to merge 1 commit intoaiidaplugins:mainfrom
ymzhang0:workchain/supercon/fix-bugs
Open

🐛 workflow: Fix bugs in SuperConWorkChain and update convergence protocol#25
ymzhang0 wants to merge 1 commit intoaiidaplugins:mainfrom
ymzhang0:workchain/supercon/fix-bugs

Conversation

@ymzhang0
Copy link
Copy Markdown
Collaborator

  • Use epw_source for code and parent_folder_epw in get_builder_from_protocols.
  • Pass structure input to interpolation and final EPW steps.
  • Use relative difference in convergence test and tighten default convergence_threshold in protocol from 0.5 to 0.05.

- Correctly access `remote_folder` from `epw_source` outputs.
- Fix input access logic for `epw_source` code check.
- Explicitly pass `structure` input to interpolation and final EPW steps.
- Update convergence criterion to use relative difference.
- Tighten default `convergence_threshold` in protocol from 0.5 to 0.05.
@ymzhang0 ymzhang0 requested a review from mbercx January 20, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant