Skip to content

fix: correct relative path for common utils in XPU launch script#7662

Open
xiaojun-zhang wants to merge 1 commit intoai-dynamo:mainfrom
xiaojun-zhang:fix/xpu-script-relative-path
Open

fix: correct relative path for common utils in XPU launch script#7662
xiaojun-zhang wants to merge 1 commit intoai-dynamo:mainfrom
xiaojun-zhang:fix/xpu-script-relative-path

Conversation

@xiaojun-zhang
Copy link
Copy Markdown

@xiaojun-zhang xiaojun-zhang commented Mar 27, 2026

Summary

  • Fix incorrect relative paths in examples/backends/vllm/launch/xpu/disagg_multimodal_epd_xpu.sh (introduced in feat: Update XPU dockerfile with vllm-v0.17.1 #7500)
  • The script was copy-pasted from launch/disagg_multimodal_epd.sh but lives one directory deeper (launch/xpu/), so the source paths need an extra ../ to reach examples/common/
  • Without this fix, the script fails immediately with: No such file or directory: .../backends/vllm/common/gpu_utils.sh

Test plan

  • Verified the fix resolves the path correctly to examples/common/gpu_utils.sh and launch_utils.sh
  • Tested end-to-end on XPU server: ran DEVICE_PLATFORM='xpu' bash disagg_multimodal_epd_xpu.sh --model Qwen/Qwen2.5-VL-3B-Instruct successfully with the fix applied

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed path references in XPU backend example deployment script to ensure correct resource loading.

@xiaojun-zhang xiaojun-zhang requested review from a team as code owners March 27, 2026 04:38
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi xiaojun-zhang! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added fix external-contribution Pull request is from an external contributor backend::vllm Relates to the vllm backend labels Mar 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6e1107e8-0774-41e8-8217-d910539bb417

📥 Commits

Reviewing files that changed from the base of the PR and between 06f1701 and e3c291a.

📒 Files selected for processing (1)
  • examples/backends/vllm/launch/xpu/disagg_multimodal_epd_xpu.sh

Walkthrough

Updated relative source paths in a shell script to reference utility files at a deeper directory level. Changed import paths from ../../../common/ to ../../../../common/ for gpu_utils.sh and launch_utils.sh. No functional logic modifications.

Changes

Cohort / File(s) Summary
Shell Script Path Corrections
examples/backends/vllm/launch/xpu/disagg_multimodal_epd_xpu.sh
Adjusted relative directory depth in source directives for utility file imports, updating path traversal from three levels to four levels (../../../../../../../).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing incorrect relative paths in an XPU launch script to reach the correct common utilities directory.
Description check ✅ Passed The description includes all required template sections (Overview/Summary, Details with specific changes, reviewer guidance on file location, and related issue reference #7500) with clear explanations and test verification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rmccorm4
Copy link
Copy Markdown
Contributor

Hi @xiaojun-zhang, thanks for the fix - please fix the failing DCO check on your commit (needs --signoff)

The XPU script was copy-pasted from the parent launch directory but
lives one level deeper (launch/xpu/ vs launch/), so the source paths
need an extra ../ to reach examples/common/.

Signed-off-by: Xiaojun Zhang <[email protected]>
@xiaojun-zhang xiaojun-zhang force-pushed the fix/xpu-script-relative-path branch from e3c291a to c4bec66 Compare March 27, 2026 18:29
@xiaojun-zhang
Copy link
Copy Markdown
Author

Hi @xiaojun-zhang, thanks for the fix - please fix the failing DCO check on your commit (needs --signoff)

fixed the DCO failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend::vllm Relates to the vllm backend external-contribution Pull request is from an external contributor fix size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants