fix: correct relative path for common utils in XPU launch script#7662
fix: correct relative path for common utils in XPU launch script#7662xiaojun-zhang wants to merge 1 commit intoai-dynamo:mainfrom
Conversation
|
👋 Hi xiaojun-zhang! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated relative source paths in a shell script to reference utility files at a deeper directory level. Changed import paths from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @xiaojun-zhang, thanks for the fix - please fix the failing DCO check on your commit (needs --signoff) |
The XPU script was copy-pasted from the parent launch directory but lives one level deeper (launch/xpu/ vs launch/), so the source paths need an extra ../ to reach examples/common/. Signed-off-by: Xiaojun Zhang <[email protected]>
e3c291a to
c4bec66
Compare
fixed the DCO failure. |
Summary
examples/backends/vllm/launch/xpu/disagg_multimodal_epd_xpu.sh(introduced in feat: Update XPU dockerfile with vllm-v0.17.1 #7500)launch/disagg_multimodal_epd.shbut lives one directory deeper (launch/xpu/), so thesourcepaths need an extra../to reachexamples/common/No such file or directory: .../backends/vllm/common/gpu_utils.shTest plan
examples/common/gpu_utils.shandlaunch_utils.shDEVICE_PLATFORM='xpu' bash disagg_multimodal_epd_xpu.sh --model Qwen/Qwen2.5-VL-3B-Instructsuccessfully with the fix applied🤖 Generated with Claude Code
Summary by CodeRabbit