feat(helm): add extraEnv support to operator deployment#7650
feat(helm): add extraEnv support to operator deployment#7650AsadShahid04 wants to merge 1 commit intoai-dynamo:mainfrom
Conversation
Add extraEnv field to Helm chart values to allow users to inject additional environment variables into the operator pod without modifying deployment templates directly. Useful for proxy configuration and other runtime environment customization. Fixes ai-dynamo#7066 Signed-off-by: Asad Shahid <[email protected]>
|
👋 Hi AsadShahid04! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
WalkthroughAdded Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
deploy/helm/charts/platform/components/operator/values.yaml (1)
27-30: Consider exposing this key in umbrella chart defaults for discoverability.This addition is good here, but if most users configure
deploy/helm/charts/platform/values.yaml, mirroringdynamo-operator.extraEnvthere would make the new capability easier to find and use.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deploy/helm/charts/platform/components/operator/values.yaml` around lines 27 - 30, Add discoverability by exposing the new operator extraEnv key in the umbrella chart defaults: mirror the operator chart key extraEnv under the umbrella values as dynamo-operator.extraEnv (or the existing operator stanza name) so users configuring deploy/helm/charts/platform/values.yaml can set environment vars for the operator; update any README/comments to mention dynamo-operator.extraEnv and ensure templating still reads .Values.dynamo-operator.extraEnv when rendering the operator Deployment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@deploy/helm/charts/platform/components/operator/values.yaml`:
- Around line 27-30: Add discoverability by exposing the new operator extraEnv
key in the umbrella chart defaults: mirror the operator chart key extraEnv under
the umbrella values as dynamo-operator.extraEnv (or the existing operator stanza
name) so users configuring deploy/helm/charts/platform/values.yaml can set
environment vars for the operator; update any README/comments to mention
dynamo-operator.extraEnv and ensure templating still reads
.Values.dynamo-operator.extraEnv when rendering the operator Deployment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 833216f2-28d1-4c34-aedc-60ad4eca9275
📒 Files selected for processing (2)
deploy/helm/charts/platform/components/operator/templates/deployment.yamldeploy/helm/charts/platform/components/operator/values.yaml
Add extraEnv field to Helm chart values to allow users to inject additional environment variables into the operator pod without modifying deployment templates directly. Useful for proxy configuration and other runtime environment customization.
Fixes #7066
Summary by CodeRabbit