Skip to content

feat(helm): add extraEnv support to operator deployment#7650

Open
AsadShahid04 wants to merge 1 commit intoai-dynamo:mainfrom
AsadShahid04:fix/inf-issue-7066
Open

feat(helm): add extraEnv support to operator deployment#7650
AsadShahid04 wants to merge 1 commit intoai-dynamo:mainfrom
AsadShahid04:fix/inf-issue-7066

Conversation

@AsadShahid04
Copy link
Copy Markdown

@AsadShahid04 AsadShahid04 commented Mar 26, 2026

Add extraEnv field to Helm chart values to allow users to inject additional environment variables into the operator pod without modifying deployment templates directly. Useful for proxy configuration and other runtime environment customization.

Fixes #7066

Summary by CodeRabbit

  • New Features
    • Added support for configuring additional environment variables in operator deployments through new configuration parameters, enabling greater customization of the operator runtime environment without modifying core deployment settings.

Add extraEnv field to Helm chart values to allow users to inject
additional environment variables into the operator pod without
modifying deployment templates directly. Useful for proxy configuration
and other runtime environment customization.

Fixes ai-dynamo#7066

Signed-off-by: Asad Shahid <[email protected]>
@AsadShahid04 AsadShahid04 requested a review from a team as a code owner March 26, 2026 04:39
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi AsadShahid04! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added feat external-contribution Pull request is from an external contributor deployment::k8s Relates to dynamo deployment in kubernetes labels Mar 26, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

Walkthrough

Added extraEnv configuration support to the operator Helm chart, enabling users to inject additional environment variables into the controller-manager container via values.yaml without modifying the deployment template directly.

Changes

Cohort / File(s) Summary
Helm Deployment Template
deploy/helm/charts/platform/components/operator/templates/deployment.yaml
Renders .Values.extraEnv as YAML within the container env: list to support injected environment variables.
Helm Values Configuration
deploy/helm/charts/platform/components/operator/values.yaml
Introduces new extraEnv: [] field to define additional environment variables for the operator deployment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(helm): add extraEnv support to operator deployment' clearly and specifically summarizes the main change in the pull request.
Description check ✅ Passed The pull request description covers the overview, details of changes, and references the related issue #7066 as required by the template.
Linked Issues check ✅ Passed The pull request successfully implements the requirements from issue #7066 by adding extraEnv field support to both values.yaml and the operator deployment template.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the stated objectives: modifications to values.yaml and deployment template only, with no extraneous or unrelated code alterations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
deploy/helm/charts/platform/components/operator/values.yaml (1)

27-30: Consider exposing this key in umbrella chart defaults for discoverability.

This addition is good here, but if most users configure deploy/helm/charts/platform/values.yaml, mirroring dynamo-operator.extraEnv there would make the new capability easier to find and use.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@deploy/helm/charts/platform/components/operator/values.yaml` around lines 27
- 30, Add discoverability by exposing the new operator extraEnv key in the
umbrella chart defaults: mirror the operator chart key extraEnv under the
umbrella values as dynamo-operator.extraEnv (or the existing operator stanza
name) so users configuring deploy/helm/charts/platform/values.yaml can set
environment vars for the operator; update any README/comments to mention
dynamo-operator.extraEnv and ensure templating still reads
.Values.dynamo-operator.extraEnv when rendering the operator Deployment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@deploy/helm/charts/platform/components/operator/values.yaml`:
- Around line 27-30: Add discoverability by exposing the new operator extraEnv
key in the umbrella chart defaults: mirror the operator chart key extraEnv under
the umbrella values as dynamo-operator.extraEnv (or the existing operator stanza
name) so users configuring deploy/helm/charts/platform/values.yaml can set
environment vars for the operator; update any README/comments to mention
dynamo-operator.extraEnv and ensure templating still reads
.Values.dynamo-operator.extraEnv when rendering the operator Deployment.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 833216f2-28d1-4c34-aedc-60ad4eca9275

📥 Commits

Reviewing files that changed from the base of the PR and between a58bcc3 and 80e0053.

📒 Files selected for processing (2)
  • deploy/helm/charts/platform/components/operator/templates/deployment.yaml
  • deploy/helm/charts/platform/components/operator/values.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment::k8s Relates to dynamo deployment in kubernetes external-contribution Pull request is from an external contributor feat size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CONTRIBUTION]: Add extraEnv support to Helm chart deployment values

1 participant