Conversation
…ly PRs Signed-off-by: Krishnan Prashanth <[email protected]>
WalkthroughExtended GitHub Actions workflow to detect backend-specific changes ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/container-validation-dynamo.yml:
- Around line 200-206: The mypy TARGETS string is missing several dynamo modules
so type-checking skips changed planner files; update the TARGETS initialization
(the variable named TARGETS in the container-validation-dynamo workflow) to
include components/src/dynamo/planner, components/src/dynamo/global_planner,
components/src/dynamo/profiler, and components/src/dynamo/global_router in
addition to the existing components/src/dynamo/common,
components/src/dynamo/frontend, and components/src/dynamo/router so mypy will
run against those modules when planner-related changes are detected.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 65839c4c-cfa8-4657-b17a-4b032b70a956
📒 Files selected for processing (1)
.github/workflows/container-validation-dynamo.yml
Signed-off-by: Krishnan Prashanth <[email protected]>
Overview:
corechanged-files filter. This allowed a mypy error to ship in refactor: fold SGLang multimodal processor into encode worker #7517, requiring a follow-up fix in fix: fix MyPy issue introduced in #7517 #7562.buildandmypyjob triggers to also fire on backend changesSummary by CodeRabbit