Skip to content

ci: run scoped mypy on backend-only PRs#7636

Open
KrishnanPrash wants to merge 2 commits intomainfrom
kprashanth/mypy-coverage
Open

ci: run scoped mypy on backend-only PRs#7636
KrishnanPrash wants to merge 2 commits intomainfrom
kprashanth/mypy-coverage

Conversation

@KrishnanPrash
Copy link
Copy Markdown
Contributor

@KrishnanPrash KrishnanPrash commented Mar 25, 2026

Overview:

Summary by CodeRabbit

  • Chores
    • Enhanced continuous integration validation pipeline to provide more comprehensive testing coverage across backend implementations.

@KrishnanPrash KrishnanPrash requested a review from a team as a code owner March 25, 2026 17:50
@github-actions github-actions bot added ci Issues/PRs that reference CI build/test actions labels Mar 25, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026

Walkthrough

Extended GitHub Actions workflow to detect backend-specific changes (sglang, vllm, trtllm) via new job outputs and conditional flags. Updated build and mypy job triggers to activate on these backend changes. Refactored mypy invocations to separately type-check shared Dynamo subpackages and backend-specific targets based on detected changes.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/container-validation-dynamo.yml
Added three new backend change-detection outputs (sglang, vllm, trtllm) to the changed-files job. Expanded build and mypy job conditional triggers to include these new backend flags alongside existing core, planner, and frontend conditions. Restructured mypy command to always check shared subpackages (common, frontend, router) and conditionally append backend-specific targets; separated bindings type-check into a distinct docker invocation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: extending mypy coverage to backend-only PRs with scoped execution.
Description check ✅ Passed The description addresses Overview and Details sections explaining the problem and solution, but lacks explicit 'Where should the reviewer start?' and 'Related Issues' sections required by the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/container-validation-dynamo.yml:
- Around line 200-206: The mypy TARGETS string is missing several dynamo modules
so type-checking skips changed planner files; update the TARGETS initialization
(the variable named TARGETS in the container-validation-dynamo workflow) to
include components/src/dynamo/planner, components/src/dynamo/global_planner,
components/src/dynamo/profiler, and components/src/dynamo/global_router in
addition to the existing components/src/dynamo/common,
components/src/dynamo/frontend, and components/src/dynamo/router so mypy will
run against those modules when planner-related changes are detected.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 65839c4c-cfa8-4657-b17a-4b032b70a956

📥 Commits

Reviewing files that changed from the base of the PR and between 4b8826b and ed8b8bb.

📒 Files selected for processing (1)
  • .github/workflows/container-validation-dynamo.yml

Signed-off-by: Krishnan Prashanth <[email protected]>
@KrishnanPrash
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions ci Issues/PRs that reference CI build/test size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant