add O_DIRECTORY to fs.constants#71
Merged
agnivade merged 1 commit intoagnivade:masterfrom Jan 31, 2025
Merged
Conversation
Contributor
Author
|
I think we need to disable apparmor. |
Owner
|
Yeah, good one. Please feel free to go ahead and update the yaml file. |
Contributor
Author
|
I've created a separate PR #72 |
hajimehoshi
force-pushed
the
directory
branch
from
03091e6 to
c085f87
Compare
hajimehoshi
force-pushed
the
directory
branch
from
c085f87 to
99489af
Compare
Contributor
Author
|
I've rebased this PR. Please take a look |
Contributor
Author
This seems just a time out. |
Owner
|
It is that same flaky test which never really went away. I restarted the test. If it fails again, I'll just rip off the test for good. It's too much pain. |
Contributor
Author
|
As this is a fix for a critical issue for Go 1.24, can we merge this first? I believe retyring the test should work in the current situation. |
Owner
|
Yeah, I did retry. It passed. Going to merge it now. Thanks for the reminder. I should also send a PR to rip that test off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70