fix: require execute permission before running reconcile.sh#41
Open
xiaolai wants to merge 1 commit intoagenticnotetaking:mainfrom
Open
fix: require execute permission before running reconcile.sh#41xiaolai wants to merge 1 commit intoagenticnotetaking:mainfrom
xiaolai wants to merge 1 commit intoagenticnotetaking:mainfrom
Conversation
The session-orient hook called ops/scripts/reconcile.sh with only an existence check. Adding an executable-bit check (-x) ensures that a non-executable file accidentally placed at that path cannot be run. The change is one character and fully backward-compatible — a properly installed vault's reconcile.sh will already be executable. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix (LOW)
File:
hooks/scripts/session-orient.sh:137The hook called a vault-owned script at a fixed path with only a file-existence check:
A non-executable file accidentally placed at
ops/scripts/reconcile.sh— for example, a text file, a downloaded script that was neverchmod +x'd, or a symlink pointing elsewhere — would still be executed bybashsince bash does not require the executable bit when given a path directly.Fix
Added a
-x(executable) check alongside the existence check:This is a one-character, fully backward-compatible change. A correctly installed vault's
reconcile.shis already executable, so normal operation is unaffected. The check prevents accidental execution of a non-executable file placed at that path.Files changed
hooks/scripts/session-orient.sh