Potential fix for code scanning alert no. 51: Disabled TLS certificate check#49
Draft
whyseu wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 51: Disabled TLS certificate check#49whyseu wants to merge 1 commit into
whyseu wants to merge 1 commit into
Conversation
…e check Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/agent-network-protocol/anp/security/code-scanning/51
The safest fix is to stop calling
danger_accept_invalid_certswith a value derived from runtime options. In reqwest, certificate verification is enabled by default, so the best non-breaking secure behavior is to always keep verification on and ignore any insecure toggle.In
rust/src/wns/resolver.rs, update the client builder inresolve_handle_with_optionsso it no longer calls:.danger_accept_invalid_certs(!options.verify_ssl)and instead relies on default TLS verification (or explicitly sets
false). This preserves existing functionality for normal secure operation, keeps timeout behavior unchanged, and removes the vulnerable sink. No new imports or methods are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.