Fix unnamed placeholders extraction#25
Merged
aduth merged 2 commits intoaduth:masterfrom Aug 30, 2025
Merged
Conversation
Owner
|
Thanks for the patch! This change makes sense to me, though I'd be curious for @USERSATOSHI's feedback as well, since he authored the typings. |
Contributor
aduth
approved these changes
Aug 30, 2025
Owner
aduth
left a comment
There was a problem hiding this comment.
Thanks @USERSATOSHI for the review, and thanks again @sdnunca for the fix. I'll get this published shortly.
Owner
|
This is now published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unnamed placeholder logic skips positional placeholders, which it determines as:
%followed by anything followed by $.This causes strings such as:
to be interpreted as having a
%s with $positional placeholder, returning[].This PR makes the logic to determine positional placeholders more specific:
%followed by a number followed by $.