Skip to content

add useNativeDriver as prop#12

Open
NickLewry wants to merge 2 commits intoadorableio:masterfrom
NickLewry:nl/add-use-native-driver
Open

add useNativeDriver as prop#12
NickLewry wants to merge 2 commits intoadorableio:masterfrom
NickLewry:nl/add-use-native-driver

Conversation

@NickLewry
Copy link

No description provided.

@NickLewry
Copy link
Author

Apologies I've just realised theres another PR open that addresses this, although I believe my solution is more flexible so I'll keep it open and it's up to you.

@LucasHimelfarb
Copy link

please, i need this change...

@NickLewry
Copy link
Author

@benadamstyles @mcavaliere @BaseCase could you take a look when you get a chance please?

Copy link
Contributor

@benadamstyles benadamstyles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems ok to me, I haven't had the chance to run it though

@NickLewry
Copy link
Author

can you merge @mcavaliere @BaseCase ? thanks

@NickLewry
Copy link
Author

@benadamstyles can we merge this please?

@NickLewry
Copy link
Author

@benadamstyles @mcavaliere @BaseCase one last try

@benadamstyles
Copy link
Contributor

Sorry I don't have write access, I can review but I can't merge!

@RolandasSTRG
Copy link

@BaseCase could you please merge the request?

@xlanor
Copy link

xlanor commented Nov 3, 2020

I forked this and published it to npm, since it's affecting our devs workflows at work. Please let me know if the PR is merged so that I can remove my fork.

@johnbonds
Copy link

+1 on merging this. Pretty please with sugar on top?

@developmentByJuned
Copy link

is it merged ?

@EfeAgare
Copy link

EfeAgare commented Jul 6, 2021

Still waiting for this PR to be merge

@developmentByJuned
Copy link

developmentByJuned commented Jul 6, 2021 via email

@Thanhal-P-A
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants