Attach event listeners before adding md-leave to paper-menu content - #1360
Open
pauln wants to merge 1 commit into
Open
Attach event listeners before adding md-leave to paper-menu content#1360pauln wants to merge 1 commit into
md-leave to paper-menu content#1360pauln wants to merge 1 commit into
Conversation
Swaps the order of `waitForAnimations()` (which sets up a `transitionend` or `animationend` event listener) and the addition of the `md-leave` class to the (clone of the) content, to ensure that the listener actually gets triggered. Firefox sometimes seems to skip it otherwise - resulting in an invisible copy of the dropdown remaining in place on top of other content, preventing interaction with anything under it. Fixes adopted-ember-addons#1359
✅ Deploy Preview for ember-paper ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the order of
waitForAnimations()(which sets up atransitionendoranimationendevent listener) and the addition of themd-leaveclass to the (clone of the) content, to ensure that the listener actually gets triggered. Firefox sometimes seems to skip it otherwise - resulting in an invisible copy of the dropdown remaining in place on top of other content, preventing interaction with anything under it.Fixes #1359