fix assertion failure in paper-item due to unhandled case when action… - #1353
Open
xud6 wants to merge 1 commit into
Open
fix assertion failure in paper-item due to unhandled case when action…#1353xud6 wants to merge 1 commit into
xud6 wants to merge 1 commit into
Conversation
✅ Deploy Preview for ember-paper ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v1.0.0-beta.39, moving the mouse over a paper-item throws an Uncaught Error: Assertion Failed. This happens because handleMouseEnter and handleMouseLeave are invoked without the correct this binding.
This behavior likely existed before v1.0.0-beta.39, but was previously masked by the action helper. Removing that helper caused the underlying issue to surface. This pull request adds a guard before calling invokeAction to prevent the error from being raised.