docs(controllers): add FocusGroupController and RovingTabindexController to 2nd-gen#6118
docs(controllers): add FocusGroupController and RovingTabindexController to 2nd-gen#6118
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
There was a problem hiding this comment.
Meant to hit request changes
Can we do this with our copy/strategy so that 1st-gen and 2nd-gen are decoupled. Also can we remove hostDelegatesFocus and assume that every 2nd-gen hosts that use this will delegate focus?
Also can we create some next gen docs on how to implement this? We need this not just for consumers but for our own team members as well. Perhaps a controllers section in the storybook?
… into rajdeep/2nd-gen-rovingtabindex
|
@Rajdeepc can we consider closing/pausing on this PR in favor of the team focus management RFC? |
|
Closing in favor of the focus management RFC PR #6129 |
Description
What changed
What did NOT change
Motivation and context
These controllers are the foundation for keyboard navigation in every composite widget (toolbar, tablist, menu, listbox, radio group, grid). Moving them to 2nd-gen with thorough documentation:
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
@spectrum-web-components/core/controllersexports resolve correctly after build