fix(picker): migrated picker to FieldLabelMixin and accessible implementation of select-only combobox pattern#6090
Conversation
…web-components into nikkimk/SWC-1449-picker-as-combobox
…web-components into nikkimk/SWC-1449-picker-as-combobox
|
…t and label in combobox button
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
formFieldMixin and accessible implmentation of select-only combobox pattern
formFieldMixin and accessible implmentation of select-only combobox patternFieldLabelMixin and accessible implementation of select-only combobox pattern
Description
FieldLabelMixin<sp-field-label>in pickerfield-label<sp-field-label>in pickerplaceholderfield-labelplaceholder<sp-field-label>in pickernameandvaluein a11y tree, including cross browser support for icons-only implementation<sp-field-label>in pickerMotivation and context
Add placeholder functionality to Picker components to provide better user experience and address consumer misuse of label attributes as placeholders. While placeholders are controversial in accessibility circles, there is still interest in implementing them as evidenced by design team discussions. This feature will introduce proper placeholder support while maintaining backward compatibility and accessibility compliance.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Ignore the following failing tests:
nikkimk/form-field-mixinbranchnikkimk/form-field-mixinbranch to be mergednikkimk/form-field-mixinbranch to be mergedUsing the picker documentation and Storybook examples:
Device review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.
Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.