Skip to content

Conversation

@nikkimk
Copy link
Contributor

@nikkimk nikkimk commented Dec 18, 2025

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

caseyisonit and others added 30 commits December 2, 2025 13:40
* chore: two ways of working with markdown files for guides

* chore: cursor rule for migrating markdown to mdx if needed

* chore: stubbed docs and ordered them

* chore: lint fix
* docs(a11y): added a11y guides to storybook

* docs(a11y): fixed typo
* chore: two doc blocks to get custom docs added to the template

* chore: clean upa few things

* chore: usage stories and descriptions for custom doc blocks

* chore: streamlining tags in stories and created capitalize utility

* chore: review fixes

* chore: updated tags in stories to new pattern
* docs(progress-circle): updated and formatted progress circle dpcs

* docs(divider): updated and formatted divider stories

* docs(divider): added size args to stories

* docs(status-ligt): updated status-light docs and stories

* docs(progress-circle): added progress arg type for docs and stories

* docs(divider): added description to stories and docs

* docs(badge): added description to stories and docs

* docs(status-light): made correction to docs

* docs(status-light): made correction to docs

* docs(badge): updated badge docs and stories

* docs: fixed typos

* docs: removed the 'usage' tag from stories

* docs(assets): updates asset docs and stories
* docs(contributor-guides): mrigrated contributor guides

* docs(contributor-docs): updated contributor docs to reflect storybook migration

* docs(contributor-guides): updated based on new IA and use of storybook

* docs(contributor-guides): fixed MDX errors

* docs(contributor-guides): fixed TOC

* docs(contributor-guides): fixed typo

* docs(contributor-guides): fixed TOC

* docs(project-planning): migrated project-planning docs to storybook

* docs(project-planning): fixed typo

* docs(guides): fixed links
* chore: two doc blocks to get custom docs added to the template

* chore: clean upa few things

* chore: usage stories and descriptions for custom doc blocks

* chore: streamlining tags in stories and created capitalize utility

* chore: review fixes

* chore: updated tags in stories to new pattern

* chore: styling sturf and starting decorators

* chore: all kinds of improvements

* chore: working on static primary story but got smart links working

* chore: clean up format and doc blocks

* chore: migrated all 2nd gen to new format, made rules, working on styles

* chore: removed tag from testing

* chore: remove console logs

* docs: updates rules for stories to include sections in the prescribed order

* docs: updated rules to remove "demo" class recommendations for headings

* docs: update exclusions for TOC headings in previews

* docs: added rule to require that all stories are accessible

* docs: status-light updates stories based on revised rules

* docs: added additional styling parameters to flex layout decorator

* docs: updated preview for better source code in docs

* docs(status-light): updated status light based on new rules

* docs(badge): updated docs according to updated rules

* docs: updated flex-layout decorator for addtional styling options

* docs: added a static colors decorator that displays both satic colors as a single story

* docs: added a static colors decorator that displays both satic colors as a single story

* docs: update rules to include static colors decorator

* docs(divider): updated divider based on updated rules

* docs: added a simple static colors exmaple to rules

* docs(progress-circle): updated progress circle docs according to updated rules

* docs(divider): simplified static colors story for divder and updated rules

---------

Co-authored-by: Casey Eickhoff <[email protected]>
* docs: updated flex-layout decorator to opt-in

* docs: updating stories

* docs: updated stories and section order

* docs: updated rules

* docs: updated contributor docs for migrating stories

* docs: updated documentation

* docs: updated documentation

* Merge branch 'garage-week/docs-rocks' of github.com:adobe/spectrum-web-components into nikkimk/docs-rocks-refinements

* docs: updated docs and rules to include picsum photos

* docs: removed static-color-wrapper helper

* docs: fixed sorting of getting started docs
* docs: updated about SWC with Kari's edits

* docs: renamed get-started to about-swc

* docs: fixed table import

* docs: added documentation styl guide to style guides
nikkimk and others added 5 commits December 17, 2025 08:51
* chore: fix weird react error, remove unused assets

* chore: removed unused helper and update docs

* chore: clean up a little, test the template pattern with slots

* chore: adobt size arg fix from ruben and clean up

* chore: direction addon in toolbar and some global controls

* chore: status light story cleanup

* chore: story clean up

* chore: clean up and stories with types

* chore: applying cleaner pattern

* chore: fix broken badge type

* chore: update rules and final styling

* chore: clean up of flex styling

* chore: progress circle clean

* chore: asset and divider clean

* chore: doc clean up with new patterns

* chore: docs have pretty pictures and source code is linted

* chore: the final pass

* docs: moved docs to learn-about-swc

* chore: apply suggestions from code review

Co-authored-by: Nikki Massaro <[email protected]>

* chore: the final final pass

---------

Co-authored-by: Nikki Massaro <[email protected]>
Co-authored-by: Nikki Massaro <[email protected]>
@nikkimk nikkimk requested a review from a team as a code owner December 18, 2025 16:19
@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

⚠️ No Changeset found

Latest commit: 3d240a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nikkimk nikkimk requested a review from caseyisonit December 18, 2025 16:36
@github-actions
Copy link
Contributor

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5945

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Base automatically changed from garage-week/docs-rocks to main January 28, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants