chore: release docs update plus auto publish docs site#5436
chore: release docs update plus auto publish docs site#5436caseyisonit merged 10 commits intomainfrom
Conversation
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
| limit: 50 | ||
| exclude_labels: blocked,wip | ||
| include_labels: in-review,ready-for-merge | ||
| include_labels: ready-for-review,ready-for-merge |
There was a problem hiding this comment.
this is the label we use in swc repo, @castastrophe let me know if I'm misunderstanding the word label here :)
There was a problem hiding this comment.
nit
what will happen with this change?
There was a problem hiding this comment.
Yeah, that makes sense to me. That utility will auto-rebase PRs with either of those labels present.
There was a problem hiding this comment.
Honestly the utility can be a bit aggressive when used so I generally suggest a separate flag for it like "auto-update" to make sure you're opting into it specifically.
There was a problem hiding this comment.
@castastrophe should we change the label and update our PR docs to include a section about updating base?
There was a problem hiding this comment.
would love to better understand what you mean when you say "aggressive", maybe we sync in slack or huddle?
Tachometer resultsCurrently, no packages are changed by this PR... |
castastrophe
left a comment
There was a problem hiding this comment.
This looks so great! One nit, if there's only 1 item in the list, we can probably just list it without the indent.
blunteshwar
left a comment
There was a problem hiding this comment.
Great work!
Lets go!:rocket:
Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com>
…of github.com:adobe/spectrum-web-components into caseyisonit/realse-docs-update-auto-publish-docs-site
|
the smoke test isnt working because my branch name is too long, was verified in #5439 |
Description
docscommit type merges intomainready-for-review.Motivation and context
Related issue(s)
Author's checklist
Reviewer's checklist
Manual review test cases