fix(dialog,styles): remove unneeded abstraction layer for system theming - abandoned by renovate[bot] · Pull Request #5304 · adobe/spectrum-web-components

renovate · 2025-03-28T17:15:54Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@spectrum-css/dialog (source)	`11.0.0-s2-foundations.15` -> `12.1.0`

Release Notes

adobe/spectrum-css (@spectrum-css/dialog)

Remove empty theme references to reduce complexity for components that don't need to define any mappings. This involves removing the source themes directories with the empty spectrum.css and express.com files as well as removing the following empty or unnecessary exports:
- index-base.css
- index-theme.css
- themes/spectrum.css
- themes/express.css

Patch Changes

Updated dependencies [c8194b0, 562396e, 562396e]:
- @spectrum-css/underlay @5.0.0
- @spectrum-css/modal @6.0.0
- @spectrum-css/tokens @15.1.0
- @spectrum-css/divider @4.0.0
- @spectrum-css/closebutton @5.4.0

`v11.0.0-s2-foundations.17`

Compare Source

Major Changes

#2786 7fa37a7 Thanks @pfulton! - Removes empty theme assets from the component; no longer publishing a themes folder or index-theme.css map.

Patch Changes

Updated dependencies [7fa37a7]:
- @spectrum-css/underlay @5.0.0-s2-foundations.17

`v11.0.0-s2-foundations.16`

Compare Source

Major Changes

#2786 f6ad55e Thanks @pfulton! - feat: s2 foundations non-gray-800 colors update

Property name	Context	Old value	Updated value
`--spectrum-blue-800`	dark	rgb(69, 110, 254)	rgb(64, 105, 253)
`--spectrum-red-800`	dark	rgb(230, 54, 35)	rgb(223, 52, 34)
`--spectrum-orange-800`	dark	rgb(205, 86, 0)	rgb(199, 82, 0)
`--spectrum-yellow-800`	dark	rgb(169, 110, 0)	rgb(164, 106, 0)
`--spectrum-chartreuse-800`	dark	rgb(109, 131, 0)	rgb(106, 127, 0)
`--spectrum-celery-800`	dark	rgb(69, 138, 19)	rgb(66, 134, 18)
`--spectrum-green-800`	dark	rgb(6, 140, 82)	rgb(6, 136, 80)
`--spectrum-seafoam-800`	dark	rgb(8, 138, 116)	rgb(8, 134, 112)
`--spectrum-cyan-800`	dark	rgb(15, 128, 194)	rgb(13, 125, 186)
`--spectrum-indigo-800`	dark	rgb(119, 97, 252)	rgb(116, 91, 252)
`--spectrum-purple-800`	dark	rgb(161, 84, 229)	rgb(157, 78, 228)
`--spectrum-fuchsia-800`	dark	rgb(192, 64, 212)	rgb(186, 60, 206)
`--spectrum-magenta-800`	dark	rgb(231, 41, 105)	rgb(224, 38, 101)
`--spectrum-pink-800`	dark	rgb(220, 47, 156)	rgb(213, 45, 151)
`--spectrum-turqoise-800`	dark	rgb(9, 135, 147)	rgb(9, 131, 142)
`--spectrum-brown-800`	dark	rgb(148, 118, 73)	rgb(143, 114, 69)
`--spectrum-silver-800`	dark	rgb(123, 123, 123)	rgb(118, 118, 118)
`--spectrum-cinnamon-800`	dark	rgb(179, 103, 64)	rgb(176, 98, 59)

Patch Changes

Updated dependencies [f6ad55e]:
- @spectrum-css/tokens @15.0.0-s2-foundations.29
- @spectrum-css/closebutton @6.0.0-s2-foundations.17
- @spectrum-css/underlay @5.0.0-s2-foundations.16
- @spectrum-css/divider @4.0.0-s2-foundations.16
- @spectrum-css/modal @6.0.0-s2-foundations.17

Configuration

📅 Schedule: Branch creation - "after 12pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

changeset-bot · 2025-03-28T17:15:57Z

🦋 Changeset detected

Latest commit: 180e6c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 84 packages

Name	Type
@spectrum-web-components/dialog	Patch
@spectrum-web-components/styles	Patch
@spectrum-web-components/contextual-help	Patch
@spectrum-web-components/bundle	Patch
@spectrum-web-components/card	Patch
@spectrum-web-components/illustrated-message	Patch
@spectrum-web-components/custom-vars-viewer	Patch
example-project-rollup	Patch
example-project-webpack	Patch
@spectrum-web-components/vrt-compare	Patch
@spectrum-web-components/theme	Patch
@spectrum-web-components/truncated	Patch
documentation	Patch
@spectrum-web-components/overlay	Patch
@spectrum-web-components/slider	Patch
@spectrum-web-components/story-decorator	Patch
@spectrum-web-components/combobox	Patch
@spectrum-web-components/menu	Patch
@spectrum-web-components/picker	Patch
@spectrum-web-components/popover	Patch
@spectrum-web-components/tooltip	Patch
@spectrum-web-components/breadcrumbs	Patch
@spectrum-web-components/action-menu	Patch
@spectrum-web-components/action-bar	Patch
@spectrum-web-components/eslint-plugin	Patch
@spectrum-web-components/accordion	Patch
@spectrum-web-components/action-button	Patch
@spectrum-web-components/action-group	Patch
@spectrum-web-components/alert-banner	Patch
@spectrum-web-components/alert-dialog	Patch
@spectrum-web-components/asset	Patch
@spectrum-web-components/avatar	Patch
@spectrum-web-components/badge	Patch
@spectrum-web-components/button-group	Patch
@spectrum-web-components/button	Patch
@spectrum-web-components/checkbox	Patch
@spectrum-web-components/clear-button	Patch
@spectrum-web-components/close-button	Patch
@spectrum-web-components/coachmark	Patch
@spectrum-web-components/color-area	Patch
@spectrum-web-components/color-field	Patch
@spectrum-web-components/color-handle	Patch
@spectrum-web-components/color-loupe	Patch
@spectrum-web-components/color-slider	Patch
@spectrum-web-components/color-wheel	Patch
@spectrum-web-components/divider	Patch
@spectrum-web-components/dropzone	Patch
@spectrum-web-components/field-group	Patch
@spectrum-web-components/field-label	Patch
@spectrum-web-components/help-text	Patch
@spectrum-web-components/icon	Patch
@spectrum-web-components/icons-ui	Patch
@spectrum-web-components/icons-workflow	Patch
@spectrum-web-components/icons	Patch
@spectrum-web-components/iconset	Patch
@spectrum-web-components/infield-button	Patch
@spectrum-web-components/link	Patch
@spectrum-web-components/meter	Patch
@spectrum-web-components/modal	Patch
@spectrum-web-components/number-field	Patch
@spectrum-web-components/picker-button	Patch
@spectrum-web-components/progress-bar	Patch
@spectrum-web-components/progress-circle	Patch
@spectrum-web-components/radio	Patch
@spectrum-web-components/search	Patch
@spectrum-web-components/sidenav	Patch
@spectrum-web-components/split-view	Patch
@spectrum-web-components/status-light	Patch
@spectrum-web-components/swatch	Patch
@spectrum-web-components/switch	Patch
@spectrum-web-components/table	Patch
@spectrum-web-components/tabs	Patch
@spectrum-web-components/tags	Patch
@spectrum-web-components/textfield	Patch
@spectrum-web-components/thumbnail	Patch
@spectrum-web-components/toast	Patch
@spectrum-web-components/top-nav	Patch
@spectrum-web-components/tray	Patch
@spectrum-web-components/underlay	Patch
@spectrum-web-components/base	Patch
@spectrum-web-components/grid	Patch
@spectrum-web-components/opacity-checkerboard	Patch
@spectrum-web-components/reactive-controllers	Patch
@spectrum-web-components/shared	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coveralls · 2025-03-28T17:25:16Z

Pull Request Test Coverage Report for Build 14134736568

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.002%

Totals
Change from base Build 14134663351:	0.0%
Covered Lines:	33711
Relevant Lines:	34211

💛 - Coveralls

github-actions · 2025-03-28T17:26:47Z

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions · 2025-03-28T17:31:04Z

Tachometer results

Chrome

dialog permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	563 kB	78.99ms - 80.55ms	-	unsure 🔍 -2% - +1% -1.66ms - +1.08ms
branch	537 kB	78.93ms - 81.19ms	unsure 🔍 -1% - +2% -1.08ms - +1.66ms	-

Firefox

dialog permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	563 kB	119.49ms - 125.95ms	-	unsure 🔍 -5% - +2% -6.06ms - +2.62ms
branch	537 kB	121.54ms - 127.34ms	unsure 🔍 -2% - +5% -2.62ms - +6.06ms	-

renovate · 2025-03-31T22:21:15Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

caseyisonit · 2025-04-01T14:51:26Z

@castastrophe does the golden hash need to be updated? i don't want it to feel like its all on you to handle the renovate PRs so let me know if you'd like me to help

castastrophe · 2025-04-01T15:12:52Z

@castastrophe does the golden hash need to be updated? i don't want it to feel like its all on you to handle the renovate PRs so let me know if you'd like me to help

Thanks! I appreciate the offer. I'm holding off on any updates that are showing visual diffs. I'll go through and remove the ready flag from those! Thanks for the reminder.

castastrophe · 2025-04-23T16:50:44Z

@caseyisonit This update is altering the inline size of the dialog for consumers and I'm not sure that's desirable at this time - should we close this update out? Are there any features in it that are really valuable? I didn't see any other changes we'd necessarily need.

renovate · 2025-05-21T15:30:43Z

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

github-actions · 2025-07-23T13:47:49Z

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5304

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

renovate Bot requested a review from a team as a code owner March 28, 2025 17:15

renovate Bot added the Spectrum CSS label Mar 28, 2025

renovate Bot force-pushed the renovate/spectrum-css-dialog-11.x branch 8 times, most recently from 6f9e0ee to e3e78a2 Compare March 31, 2025 21:44

castastrophe self-assigned this Mar 31, 2025

castastrophe changed the title ~~chore: update dependency @spectrum-css/dialog to v11.0.1~~ chore: update dependency @spectrum-css/dialog to v12.1.0 Mar 31, 2025

castastrophe added Component:Dialog Status:Ready for review PR ready for review or re-review. labels Mar 31, 2025

castastrophe removed the Status:Ready for review PR ready for review or re-review. label Apr 1, 2025

castastrophe force-pushed the renovate/spectrum-css-dialog-11.x branch 6 times, most recently from 3ee92ca to 1c6303b Compare April 2, 2025 18:10

castastrophe added the Status:On hold PR on hold for whatever reason, including the work requiring more discussion label Apr 2, 2025

castastrophe force-pushed the renovate/spectrum-css-dialog-11.x branch from 1c6303b to 5210b62 Compare April 4, 2025 22:52

castastrophe force-pushed the renovate/spectrum-css-dialog-11.x branch 3 times, most recently from f77d2bf to 2d12fb2 Compare April 23, 2025 16:31

castastrophe force-pushed the renovate/spectrum-css-dialog-11.x branch from 2d12fb2 to 6488405 Compare April 25, 2025 22:28

castastrophe force-pushed the renovate/spectrum-css-dialog-11.x branch 4 times, most recently from 53a9013 to fc960b3 Compare May 7, 2025 20:51

renovate Bot changed the title ~~chore: update dependency @spectrum-css/dialog to v12.1.0~~ chore: update dependency @spectrum-css/dialog to v12.1.0 - abandoned May 21, 2025

castastrophe force-pushed the renovate/spectrum-css-dialog-11.x branch 4 times, most recently from 8c1fb09 to c7b4e91 Compare May 27, 2025 14:13

castastrophe changed the title ~~chore: update dependency @spectrum-css/dialog to v12.1.0 - abandoned~~ fix(dialog,styles): remove unneeded abstraction layer for system theming May 27, 2025

renovate Bot changed the title ~~fix(dialog,styles): remove unneeded abstraction layer for system theming~~ fix(dialog,styles): remove unneeded abstraction layer for system theming - abandoned May 27, 2025

castastrophe force-pushed the renovate/spectrum-css-dialog-11.x branch 2 times, most recently from b389daa to ec249e9 Compare June 10, 2025 22:10

castastrophe force-pushed the renovate/spectrum-css-dialog-11.x branch from ec249e9 to fc3f5f5 Compare June 23, 2025 21:15

renovate Bot and others added 5 commits July 23, 2025 09:59

chore: update dependency @spectrum-css/dialog to v11.0.1

8a9efdc

fix(dialog,styles): use latest CSS

11e7f83

chore: prettier settings for all CSS

fcd232d

chore: update dependency @spectrum-css/dialog to v11.0.1

d4319c1

fix(dialog,styles): use latest CSS

d0a37a9

castastrophe force-pushed the renovate/spectrum-css-dialog-11.x branch from 8ac286e to 473e9f2 Compare July 23, 2025 13:59

chore: prettier settings for all CSS

180e6c2

castastrophe force-pushed the renovate/spectrum-css-dialog-11.x branch from 473e9f2 to 180e6c2 Compare July 23, 2025 14:16

castastrophe closed this Sep 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dialog,styles): remove unneeded abstraction layer for system theming - abandoned#5304

fix(dialog,styles): remove unneeded abstraction layer for system theming - abandoned#5304
renovate[bot] wants to merge 6 commits intomainfrom
renovate/spectrum-css-dialog-11.x

renovate Bot commented Mar 28, 2025 •

edited by castastrophe

Loading

Uh oh!

changeset-bot Bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

coveralls commented Mar 28, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 28, 2025 •

edited

Loading

dialog permalink

basic-test

dialog permalink

basic-test

Uh oh!

renovate Bot commented Mar 31, 2025

Uh oh!

caseyisonit commented Apr 1, 2025

Uh oh!

castastrophe commented Apr 1, 2025

Uh oh!

castastrophe commented Apr 23, 2025

Uh oh!

renovate Bot commented May 21, 2025

Uh oh!

github-actions Bot commented Jul 23, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

renovate Bot commented Mar 28, 2025 • edited by castastrophe Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes

v11.0.1

Patch Changes

v11.0.0

Major Changes

Patch Changes

v11.0.0-s2-foundations.17

Major Changes

Patch Changes

v11.0.0-s2-foundations.16

Major Changes

Patch Changes

Configuration

Uh oh!

changeset-bot Bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coveralls commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 14134736568

Details

💛 - Coveralls

Uh oh!

github-actions Bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Branch preview

Review the following VRT differences

Uh oh!

github-actions Bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tachometer results

dialog permalink

basic-test

dialog permalink

basic-test

Uh oh!

renovate Bot commented Mar 31, 2025

Edited/Blocked Notification

Uh oh!

caseyisonit commented Apr 1, 2025

Uh oh!

castastrophe commented Apr 1, 2025

Uh oh!

castastrophe commented Apr 23, 2025

Uh oh!

renovate Bot commented May 21, 2025

Autoclosing Skipped

Uh oh!

github-actions Bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Branch Preview

🔍 Visual Regression Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

renovate Bot commented Mar 28, 2025 •

edited by castastrophe

Loading

`v11.0.1`

`v11.0.0`

`v11.0.0-s2-foundations.17`

`v11.0.0-s2-foundations.16`

changeset-bot Bot commented Mar 28, 2025 •

edited

Loading

coveralls commented Mar 28, 2025 •

edited

Loading

github-actions Bot commented Mar 28, 2025 •

edited

Loading

github-actions Bot commented Mar 28, 2025 •

edited

Loading

github-actions Bot commented Jul 23, 2025 •

edited

Loading