Skip to content

fix: #8686 prevent useGridCell from overriding child focus restoration loops#10228

Open
jsmitrah wants to merge 5 commits into
adobe:mainfrom
jsmitrah:bug-fix/8686/table-cell-incorrectly-returns-focus-to-button
Open

fix: #8686 prevent useGridCell from overriding child focus restoration loops#10228
jsmitrah wants to merge 5 commits into
adobe:mainfrom
jsmitrah:bug-fix/8686/table-cell-incorrectly-returns-focus-to-button

Conversation

@jsmitrah

@jsmitrah jsmitrah commented Jun 18, 2026

Copy link
Copy Markdown

Closes #8686

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • Tab into the table row and use the arrow keys to focus on the "Open Dialog" button.
  • Press Enter to open the modal dialog, then press Escape to close it.
  • Verify that focus returns exactly to the "Open Dialog" button instead of jumping to the "Action 1" button.

🧢 Your Project:

@snowystinger snowystinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the interest, if you run yarn format it should get rid of all the noisy whitespace changes that I'm guessing your IDE applied

@jsmitrah jsmitrah force-pushed the bug-fix/8686/table-cell-incorrectly-returns-focus-to-button branch 4 times, most recently from 978338d to 0a7cf3b Compare June 18, 2026 14:58
@jsmitrah jsmitrah force-pushed the bug-fix/8686/table-cell-incorrectly-returns-focus-to-button branch from 0a7cf3b to 714723c Compare June 18, 2026 15:09
@jsmitrah jsmitrah requested a review from snowystinger June 19, 2026 05:35
@jsmitrah

Copy link
Copy Markdown
Author

Thanks @snowystinger, all tests are passed

@jsmitrah jsmitrah force-pushed the bug-fix/8686/table-cell-incorrectly-returns-focus-to-button branch from ccb8bbd to 4b28c4a Compare June 19, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table cell incorrectly returns focus to button on modal close

2 participants