Skip to content

Remove measurement dimension hack in KF #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephenswat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove measurement dimension hack in KF #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions core/include/traccc/fitting/kalman_filter/gain_matrix_updater.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
#pragma once

// Project include(s).
#include <limits>

#include "traccc/definitions/qualifiers.hpp"
#include "traccc/definitions/track_parametrization.hpp"
#include "traccc/edm/measurement_collection.hpp"
Expand Down Expand Up @@ -93,19 +95,20 @@
getter::element(H, 0u, e_bound_loc0) = -1;
}

// @TODO: Fix properly
if (/*dim == 1*/ getter::element(meas_local, 1u, 0u) == 0.f) {
getter::element(H, 1u, 0u) = 0.f;
getter::element(H, 1u, 1u) = 0.f;
if (dim == 1) {
// TODO: Fully understand the consequences of this.

Check warning on line 99 in core/include/traccc/fitting/kalman_filter/gain_matrix_updater.hpp

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 


See more on https://sonarcloud.io/project/issues?id=acts-project_traccc&issues=AZr9fSBBkFzj78kGy7Z6&open=AZr9fSBBkFzj78kGy7Z6&pullRequest=1195
assert(getter::element(H, 1u, 0u) == 0.f);
Copy link
Copy Markdown
Contributor

@niermann999 niermann999 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the subspace for line surfaces is not correct and these need to be set explicitly ?

assert(getter::element(H, 1u, 1u) == 0.f);
}

// Spatial resolution (Measurement covariance)
matrix_type<D, D> V;
edm::get_measurement_covariance<algebra_t>(
measurements.at(trk_state.measurement_index()), V);
// @TODO: Fix properly
if (/*dim == 1*/ getter::element(meas_local, 1u, 0u) == 0.f) {
getter::element(V, 1u, 1u) = 1000.f;
if (dim == 1) {
// This value should never be used!
// TODO: Fully understand the consequences of this.

Check warning on line 110 in core/include/traccc/fitting/kalman_filter/gain_matrix_updater.hpp

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 


See more on https://sonarcloud.io/project/issues?id=acts-project_traccc&issues=AZr9fSBBkFzj78kGy7Z7&open=AZr9fSBBkFzj78kGy7Z7&pullRequest=1195
getter::element(V, 1u, 1u) = std::numeric_limits<scalar>::max();
}

TRACCC_DEBUG_HOST("Measurement position: " << meas_local);
Expand Down
15 changes: 8 additions & 7 deletions core/include/traccc/fitting/kalman_filter/two_filters_smoother.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,10 @@
const subspace<algebra_t, e_bound_size> subs(
measurements.at(trk_state.measurement_index()).subspace());
matrix_type<D, e_bound_size> H = subs.template projector<D>();
// @TODO: Fix properly
if (getter::element(meas_local, 1u, 0u) == 0.f /*dim == 1*/) {
getter::element(H, 1u, 0u) = 0.f;
getter::element(H, 1u, 1u) = 0.f;
if (dim == 1) {
// TODO: Fully understand the consequences of this.

Check warning on line 139 in core/include/traccc/fitting/kalman_filter/two_filters_smoother.hpp

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 


See more on https://sonarcloud.io/project/issues?id=acts-project_traccc&issues=AZr9fR77kFzj78kGy7Z4&open=AZr9fR77kFzj78kGy7Z4&pullRequest=1195
assert(getter::element(H, 1u, 0u) == 0.f);
assert(getter::element(H, 1u, 1u) == 0.f);
}

const matrix_type<D, 1> residual_smt = meas_local - H * smoothed_vec;
Expand All @@ -147,9 +147,10 @@
matrix_type<D, D> V;
edm::get_measurement_covariance<algebra_t>(
measurements.at(trk_state.measurement_index()), V);
// @TODO: Fix properly
if (getter::element(meas_local, 1u, 0u) == 0.f /*dim == 1*/) {
getter::element(V, 1u, 1u) = 1000.f;
if (dim == 1) {
// This value should never be used!
// TODO: Fully understand the consequences of this.

Check warning on line 152 in core/include/traccc/fitting/kalman_filter/two_filters_smoother.hpp

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 


See more on https://sonarcloud.io/project/issues?id=acts-project_traccc&issues=AZr9fR77kFzj78kGy7Z5&open=AZr9fR77kFzj78kGy7Z5&pullRequest=1195
getter::element(V, 1u, 1u) = std::numeric_limits<scalar>::max();
}

TRACCC_DEBUG_HOST("Measurement position: " << meas_local);
Expand Down
Loading