feat: Add elemental fractions to the material recording step#5280
Open
56laurenwills wants to merge 1 commit intoacts-project:mainfrom
Open
feat: Add elemental fractions to the material recording step#528056laurenwills wants to merge 1 commit intoacts-project:mainfrom
56laurenwills wants to merge 1 commit intoacts-project:mainfrom
Conversation
github-actions
bot
added
Component - Core
asalzburger
previously approved these changes
Mar 25, 2026
Contributor
asalzburger
left a comment
asalzburger
left a comment
There was a problem hiding this comment.
This looks great now, depending on when this goes in we might have a conflict on the material_recording.py but a very trivial one.
Well done!
Contributor
56laurenwills
force-pushed
the
working_branch
branch
from
e087e74 to
47a11e6
Compare
…oggle to enable / disable
56laurenwills
force-pushed
the
working_branch
branch
from
47a11e6 to
9ed2810
Compare
andiwand
approved these changes
Apr 7, 2026
Contributor
andiwand
left a comment
andiwand
left a comment
There was a problem hiding this comment.
changes look good to me - thanks @56laurenwills !
the CI format check will fail though. you can either download the reformatted files from the CI, or run clang-format locally, or install the pre-commit hooks and trigger the formatting through that. let us know if you need additional help with that
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend material recording to include all elements and their fraction seen at a material interaction. Include a toggle to enable or disable this feature.
--- END COMMIT MESSAGE ---
@asalzburger @noemina - tagging for review