Skip to content

Add alignment workflow for the OpenDataDetector#4910

Open
Zequn-SUN wants to merge 231 commits intoacts-project:mainfrom
Zequn-SUN:alignTest
Open

Add alignment workflow for the OpenDataDetector#4910
Zequn-SUN wants to merge 231 commits intoacts-project:mainfrom
Zequn-SUN:alignTest

Conversation

@Zequn-SUN
Copy link
Copy Markdown

This PR introduces a complete detector alignment workflow for the OpenDataDetector (ODD), implementing a full pipeline from simulation with the nominal geometry, alignment with the misaligned geometry, to reconstructions with the nominal, misaligned, and aligned geometry, respectively. The script implementing the complete workflow is Examples/Scripts/Python/alignment_odd.py

This script needs a json file containing the transform information of each ODD sensor. This json file can be found here
https://cernbox.cern.ch/files/spaces/eos/user/z/zesun/odd_transforms.json

For detailed documentation and usage instructions, please refer to:
https://docs.google.com/document/d/1FHyWZoeHhygSMH9F7IPQbE7_Dx9tlPPXQhbNMYYZLJ8/edit?usp=sharing

--- END COMMIT MESSAGE ---

Any further description goes here, @-mentions are ok here!

  • Use a conventional commits prefix: quick summary
    • We mostly use feat, fix, refactor, docs, chore and build types.
  • A milestone will be assigned by one of the maintainers

@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Dec 15, 2025
@github-actions github-actions bot added this to the next milestone Dec 15, 2025
@asalzburger
Copy link
Copy Markdown
Contributor

Hi @Zequn-SUN - there are small conflicts due to the change of the python directories, Examples/Python does not exist in main anymore, it moved to Python/Examples.

- Removed Examples/Python/CMakeLists.txt (moved to Python/Examples)
- Updated Python/Examples/src/plugins/Alignment.cpp to use new module structure
- Preserved AlignmentMask, MutableGeoIdAlignmentStore, and AlignmentAlgorithm bindings
@github-actions github-actions bot added the Stale label Jan 14, 2026
@github-actions github-actions bot removed the Component - Plugins Affects one or more Plugins label Feb 4, 2026
@Zequn-SUN
Copy link
Copy Markdown
Author

Hi @asalzburger ,
Thanks for pointing that out. I've updated the code (https://github.com/Zequn-SUN/acts/tree/alignTest) to match the new directory structure (Python/Examples instead of Examples/Python) and merged the latest changes from main. I've also resolved the compilation errors related to the AlignedTransformUpdater API changes (switching from DetectorElementBase* to SurfacePlacementBase*) and updated the Python bindings accordingly.
Sorry for the delay in updating the PR. The changes are now pushed and should be ready for review. Please let me know if there are any other issues.

Best regards
Zequn

@github-actions github-actions bot removed the Stale label Feb 4, 2026
@github-actions github-actions bot added the Stale label Mar 6, 2026
@AJPfleger
Copy link
Copy Markdown
Contributor

Hi @Zequn-SUN @asalzburger what's the status on this PR?

@github-actions github-actions bot removed the Stale label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Core Affects the Core module Component - Examples Affects the Examples module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants