feature: Add Delegates to select doublets#4593
Draft
CarloVarni wants to merge 1 commit intoacts-project:mainfrom
Draft
feature: Add Delegates to select doublets#4593CarloVarni wants to merge 1 commit intoacts-project:mainfrom
CarloVarni wants to merge 1 commit intoacts-project:mainfrom
Conversation
github-actions
bot
added
Component - Core
Contributor
andiwand
reviewed
Aug 29, 2025
Comment on lines
+183
to
+186
| /// deltaZ maximum for bottom doublet | ||
| float maxDeltaZbottom{}; | ||
| /// deltaZ maximum for top doublet | ||
| float maxDeltaZtop{}; |
Contributor
There was a problem hiding this comment.
sorry I think I miscommunicated this - I believe this should be separate from the MiddleSpInfo
Comment on lines
+39
to
+44
| static float voidDeltaZFunc(float, float) { | ||
| return std::numeric_limits<float>::max(); | ||
| }; | ||
| static bool vetoCandidate(float, float) { | ||
| return false; | ||
| }; |
Contributor
There was a problem hiding this comment.
I think it would be easier to just leave the delegate unconnected in this case
| float deltaZ = 0; | ||
| if constexpr (isBottomCandidate) { | ||
| deltaZ = zM - zO; | ||
| if (outsideRangeCheck( std::abs(deltaZ), 0, middleSpInfo.maxDeltaZbottom)) { |
Contributor
There was a problem hiding this comment.
I think one cut should be enough for both bottom and top and set accordingly in the triplet seeder
| explicit TripletSeeder(std::unique_ptr<const Logger> logger = | ||
| getDefaultLogger("TripletSeeder", | ||
| Logging::Level::INFO)); | ||
| struct Config { |
Contributor
There was a problem hiding this comment.
can this be pushed into the TripletSeedFinder?
Contributor
|
@CarloVarni @andiwand is this one still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functionality to filter doublets and middle candidates