Skip to content

[13.0] [FIX] stock: Added a method in stock.warehouse to allow override his …#63

Open
jo541 wants to merge 1 commit into13.0from
fix/8.4-add_sudo_for_warehouse_creation_jto
Open

[13.0] [FIX] stock: Added a method in stock.warehouse to allow override his …#63
jo541 wants to merge 1 commit into13.0from
fix/8.4-add_sudo_for_warehouse_creation_jto

Conversation

@jo541
Copy link
Copy Markdown

@jo541 jo541 commented Jul 25, 2022

DO NOT MERGE

@jo541 jo541 changed the title [FIX] stock: Added a method in stock.warehouse to allow override his … [13.0] [FIX] stock: Added a method in stock.warehouse to allow override his … Jul 25, 2022
Comment on lines 102 to 103
loc_vals = {'name': _(vals.get('code')), 'usage': 'view',
'location_id': self.env.ref('stock.stock_location_locations').id}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not better to have a prepare method for this ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be even better. But we also need the _create method to place our sudo().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants