[ADD] account_perf_obligation_sale_qty_delivered

[baimont]

No description provided.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.76%. Comparing base (a2ba19d) to head (b4a3a22).

Files with missing lines	Patch %	Lines
...ation_sale_qty_delivered/models/sale_order_line.py	88.46%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             18.0      #79      +/-   ##
==========================================
- Coverage   96.80%   96.76%   -0.05%     
==========================================
  Files          80       85       +5     
  Lines        3223     3275      +52     
  Branches      169      174       +5     
==========================================
+ Hits         3120     3169      +49     
- Misses         71       72       +1     
- Partials       32       34       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sbidoul]

Where is this method called?

[baimont]

not the right question. it's a constrains, so the right question is: when is this method called: when qty_delivered changes

[sbidoul]

🤦

[sbidoul]

But but, a constraint is not supposed to have side effects.

[baimont]

that is, if you use them as intended: just to check and raise. as of now, in the account-performance-obligation project, we use them as intended. but we often use them, in other projects, as a shortcut for create and write override

here I could adapt and use the write only I guess

[sbidoul]

but we often use them, in other projects, as a shortcut for create and write override

😱

[baimont]

I adapted with create and write overrides

[sbidoul]

In this field name raw_total_excluded_currency, can you confirm that excluded means "tax excluded", and currency means company currency? Because the perf obligation amount is (currently) tax excluded, and in company currency.

[baimont]

In sale module (sale.order.line._compute_amount), price_subtotal is computed directly using raw_total_excluded_currency:
line.price_subtotal = base_line['tax_details']['raw_total_excluded_currency']
Since _get_perf_obligation_amount() in account_perf_obligation_sale returns self.price_subtotal (which is in the sale order currency), using raw_total_excluded_currency maintains consistency with the account_perf_obligation_sale module.

excluded means "tax excluded" yes
but currency does not mean company currency, it means the record currency