Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## python-dev #5782 +/- ##
==============================================
+ Coverage 95.28% 95.32% +0.03%
==============================================
Files 35 35
Lines 3031 3077 +46
==============================================
+ Hits 2888 2933 +45
- Misses 143 144 +1
🚀 New features to boost your workflow:
|
Member
|
Just request the review when you want it. |
Collaborator
|
@mbollmann Can this be closed? |
Member
Author
|
This exact PR may be out of date but the functionality is still very much at the top of my wishlist, so this would be good to keep around until I know which parts of this can be scrapped or re-used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt at implementing caching for the library, targeting PersonIndex.
In my testing, calling
anthology.people.load()takes ca. 7 seconds when building from the XML files, and ~1.5 seconds when loading from the cache file.However, when calling
anthology.load_all(), the difference is much less pronounced — maybe it's worth testing how much Collection objects would profit from caching as well.Finally, I encountered some issues during local testing where occasionally the cache file would be loaded even though it was empty, so despite the existing tests there are some more kinks to be ironed out.