Skip to content

Check the service is available before record success#92

Open
lukaskupr wants to merge 1 commit intoackintosh:masterfrom
lukaskupr:feature/check-availability-before-success
Open

Check the service is available before record success#92
lukaskupr wants to merge 1 commit intoackintosh:masterfrom
lukaskupr:feature/check-availability-before-success

Conversation

@lukaskupr
Copy link
Copy Markdown

Solve the situation when a request that was sent before the trip may immediately overwrite the success value

@ackintosh
Copy link
Copy Markdown
Owner

Thank you for your pull request.

I'm not sure this change makes sense because:

  1. As shown at the Usage, users call isAvailable prior to calling success/failure.

  2. It seems impossible to completely avoid the overwrite you mentioned, because the most key-value store does not support ACID transaction. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants