Ensure module is loaded when fetching default_url#277
Open
martosaur wants to merge 1 commit intoabsinthe-graphql:mainfrom
Open
Ensure module is loaded when fetching default_url#277martosaur wants to merge 1 commit intoabsinthe-graphql:mainfrom
martosaur wants to merge 1 commit intoabsinthe-graphql:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've run into an issue recently when we were getting
** (RuntimeError) function for default_url: {Elixir.MyModule, graphiql_default_url} is not exported with arity 1 or 0error. Both the module and the function did exist. After investigation, it turned out that for some reason by the timeabsinthe_plugwas callingfunction_exported?the module was not loaded andfunction_exported?does not do this automatically.So I believe it's worth loading the module explicitly. I also added a test which is a bit clunky, so if you know a better way to create an unloaded module please let me know!