fix: prevent @defer list-item projector crash in streaming resolution#1413
Open
svesligaj wants to merge 1 commit intoabsinthe-graphql:mainfrom
Open
fix: prevent @defer list-item projector crash in streaming resolution#1413svesligaj wants to merge 1 commit intoabsinthe-graphql:mainfrom
svesligaj wants to merge 1 commit intoabsinthe-graphql:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happens
When running incremental execution with @defer inside list items, deferred selection filtering can leave nil entries in selection lists and deferred task execution can resolve with an invalid parent shape/path; this can surface as a projector
crash (case clause mismatch) or malformed deferred payloads.
Why it happens
StreamingResolution marks deferred selections and uses blueprint traversal that replaces nodes but does not remove list entries automatically, so nils may remain in nested selections; additionally, deferred task execution may run against list containers without normalizing parent data/path for item-level resolution.
Proposed fix
phases.
Validation