fix: Handle missing registry in Subscription.unsubscribe/2 during shutdown#1411
Open
perzanko wants to merge 1 commit intoabsinthe-graphql:mainfrom
Open
fix: Handle missing registry in Subscription.unsubscribe/2 during shutdown#1411perzanko wants to merge 1 commit intoabsinthe-graphql:mainfrom
perzanko wants to merge 1 commit intoabsinthe-graphql:mainfrom
Conversation
When using SSE-based subscriptions (standard_sse: true in absinthe_plug), active connections call unsubscribe/2 during connection teardown. In a standard supervision tree where Absinthe.Subscription is started after the Endpoint (as documented), OTP terminates children in reverse start order - meaning the subscription Registry is shut down before the Endpoint finishes draining connections. This causes an ArgumentError from Registry.unregister_match/4. Guard against the missing registry using Process.whereis/1, following the same pattern already used in extract_pubsub/2. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
karolmaj4fresha
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using SSE-based subscriptions (
standard_sse: trueinabsinthe_plug), active connections callunsubscribe/2during connection teardown. In a standard supervision tree whereAbsinthe.Subscriptionis started after the Endpoint (as documented), OTP terminates children in reverse start order — meaning the subscription Registry is shut down before the Endpoint finishes draining connections.This causes an
ArgumentError: unknown registryfromRegistry.unregister_match/4during every deployment for each active SSE subscription.Fix
Guard against the missing registry using
Process.whereis/1inunsubscribe/2, following the same pattern already used inextract_pubsub/2.The process dictionary cleanup (
pdict_delete_fields) always runs regardless, so there's no resource leak.