Open
Conversation
this is my first commit to a public repo, so i don't know if i'm doing it right
dmitryvhf
suggested changes
Sep 1, 2022
dmitryvhf
left a comment
There was a problem hiding this comment.
Decline.
- The current correct code has been broken.
- StringPermutationTests discredited.
| int index = other.IndexOf(source[i]); | ||
| if(index==-1) | ||
| return false; | ||
| other.Remove(index); |
There was a problem hiding this comment.
Absolutly critical code!
- Remove(index) - remove From to End. You are drop all symbols from right.
- String immunable. "other" object it not changed.
Example:other = other.Remove(index, 1);
But this bad too - immunable string operation = bad performance, memory and etc. problem.
StringPermutationTests discredited. This test case must will be fail.
var one = "dbcdefg"; var two = "dabcgfe"; Assert.True(Permutations.IsAnargram(one, two) == true);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is my first commit to a public repo, so I don't know if I'm doing it right
Description
fixed issue #11
Checklist