fix(spec): use application/json content type in Section 6 examples#1640
fix(spec): use application/json content type in Section 6 examples#1640matanweks wants to merge 1 commit intoa2aproject:mainfrom
Conversation
The HTTP examples in Section 6 incorrectly use `application/a2a+json` as the Content-Type, which contradicts the protocol requirements defined in Section 9.1 (JSON-RPC) and Section 11.1 (HTTP+JSON/REST) that both specify `application/json` for requests and responses. Fixes a2aproject#1639
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an inconsistency within the specification documentation by standardizing the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Content-Type header in 18 examples in Section 6 to application/json, aligning them with the protocol requirements in Sections 9.1 and 11.1. The changes improve the consistency of the specification. While reviewing the surrounding documentation, I noticed a separate inconsistency in the 'Validation Error Example' within Section 6.5. The example error message on line 1587 for an invalid status parameter lists values ('pending', 'working', etc.) that are inconsistent with the SCREAMING_SNAKE_CASE format required for TaskState enum values and includes a 'pending' state which is not defined. This is outside the scope of the current changes but would be a valuable correction for a future pull request to ensure the specification is fully consistent.
Summary
application/a2a+jsonas theContent-Typeheaderapplication/json, consistent with:Content-Type: application/json for requests and responsesContent-Type: application/json for requests and responsesapplication/jsonFixes #1639
Test plan
Content-Typeheaders in Section 6 examples now readapplication/jsonapplication/a2a+json