-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(spec): Provide ability for SDKs to be backwards compatible. #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spec): Provide ability for SDKs to be backwards compatible. #1401
Conversation
Summary of ChangesHello @herczyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the gRPC API definitions and improving backward compatibility for agents. It streamlines gRPC configurations by removing redundant bindings and introduces explicit protocol versioning for agent interfaces. Additionally, it deprecates older transport-related fields in the AgentCard message, signaling a shift towards newer, more standardized transport mechanisms. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request effectively addresses backward compatibility concerns by refining the A2A protocol's versioning strategy. The relocation of protocol_versions from AgentCard to AgentInterface is a logical improvement, allowing for more granular versioning per transport. The deprecation of older fields in AgentCard with clear comments is a good practice for maintaining backward compatibility while signaling future removals. The changes also include some minor formatting adjustments in the additional_bindings sections, with a suggestion to maintain multi-line formatting for readability.
…lity' into backwards_compatibility
|
/vote |
Vote created@herczyn has called for a vote on The members of the following teams have binding votes:
Non-binding votes are also appreciated as a sign of support! How to voteYou can cast your vote by reacting to
Please note that voting for multiple options is not allowed and those votes won't be counted. The vote will be open for |
Vote statusSo far Summary
Binding votes (0)
|
| User | Vote | Timestamp |
|---|---|---|
| Tehsmash | In favor | 2026-01-28 9:05:01.0 +00:00:00 |
| herczyn | In favor | 2026-01-28 13:48:56.0 +00:00:00 |
muscariello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
i assume we still wait for the vote, right? |
Vote statusSo far Summary
Binding votes (6)
|
| User | Vote | Timestamp |
|---|---|---|
| Tehsmash | In favor | 2026-01-28 9:05:01.0 +00:00:00 |
| herczyn | In favor | 2026-01-28 13:48:56.0 +00:00:00 |
| holtskinner | In favor | 2026-01-29 15:49:14.0 +00:00:00 |
Vote closedThe vote passed! 🎉
Summary
Binding votes (6)
|
| User | Vote | Timestamp |
|---|---|---|
| @Tehsmash | In favor | 2026-01-28 9:05:01.0 +00:00:00 |
| @herczyn | In favor | 2026-01-28 13:48:56.0 +00:00:00 |
| @holtskinner | In favor | 2026-01-29 15:49:14.0 +00:00:00 |
fixes #1417
for context see #1416