Skip to content

Conversation

@herczyn
Copy link
Member

@herczyn herczyn commented Jan 22, 2026

fixes #1417
for context see #1416

@herczyn herczyn requested a review from a team as a code owner January 22, 2026 16:14
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @herczyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the gRPC API definitions and improving backward compatibility for agents. It streamlines gRPC configurations by removing redundant bindings and introduces explicit protocol versioning for agent interfaces. Additionally, it deprecates older transport-related fields in the AgentCard message, signaling a shift towards newer, more standardized transport mechanisms.

Highlights

  • gRPC API Updates: Modified the a2a.proto file to streamline gRPC API definitions by removing redundant additional_bindings in google.api.http options for methods like GetTask, ListTasks, SubscribeToTask, GetTaskPushNotificationConfig, ListTaskPushNotificationConfig, GetExtendedAgentCard, and DeleteTaskPushNotificationConfig.
  • Agent Interface Enhancements: Added protocol_versions field to the AgentInterface message in a2a.proto to explicitly define supported A2A protocol versions, ensuring backward compatibility. The field is required and should list the latest supported minor version per major version (e.g., ["0.3", "1.0"]).
  • AgentCard Deprecation: Deprecated several fields in the AgentCard message of a2a.proto, including url, preferred_transport, and additional_interfaces. These fields are marked as deprecated and are intended for use only with the 0.3 version of the transport, indicating a move towards newer transport mechanisms.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively addresses backward compatibility concerns by refining the A2A protocol's versioning strategy. The relocation of protocol_versions from AgentCard to AgentInterface is a logical improvement, allowing for more granular versioning per transport. The deprecation of older fields in AgentCard with clear comments is a good practice for maintaining backward compatibility while signaling future removals. The changes also include some minor formatting adjustments in the additional_bindings sections, with a suggestion to maintain multi-line formatting for readability.

@holtskinner holtskinner changed the title [spec]: Provide ability for SDKs to be backwards compatible. feat(spec): Provide ability for SDKs to be backwards compatible. Jan 22, 2026
@herczyn herczyn added TSC Review To be reviewed by the Technical Steering Committee P1 Priority for TSC Review labels Jan 26, 2026
@github-project-automation github-project-automation bot moved this to Backlog in TSC Review Jan 26, 2026
@herczyn
Copy link
Member Author

herczyn commented Jan 27, 2026

/vote

@git-vote
Copy link

git-vote bot commented Jan 27, 2026

Vote created

@herczyn has called for a vote on feat(spec): Provide ability for SDKs to be backwards compatible. (#1401).

The members of the following teams have binding votes:

Team
@a2aproject/a2a-tsc

Non-binding votes are also appreciated as a sign of support!

How to vote

You can cast your vote by reacting to this comment. The following reactions are supported:

In favor Against Abstain
👍 👎 👀

Please note that voting for multiple options is not allowed and those votes won't be counted.

The vote will be open for 11months 29days 3h 50m 24s. It will pass if at least 51% of the users with binding votes vote In favor 👍. Once it's closed, results will be published here as a new comment.

@git-vote
Copy link

git-vote bot commented Jan 28, 2026

Vote status

So far 0.00% of the users with binding vote are in favor and 0.00% are against (passing threshold: 51%).

Summary

In favor Against Abstain Not voted
0 0 0 8

Binding votes (0)

User Vote Timestamp
@muscariello Pending
@darrelmiller Pending
@geneknit Pending
@hughesthe1st Pending
@ToddSegal Pending
@000-000-000-000-000 Pending
@SivaNSAP Pending
@spetschulatSFDC Pending

Non-binding votes (2)

User Vote Timestamp
Tehsmash In favor 2026-01-28 9:05:01.0 +00:00:00
herczyn In favor 2026-01-28 13:48:56.0 +00:00:00

@muscariello muscariello self-requested a review January 29, 2026 12:43
Copy link
Member

@muscariello muscariello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herczyn
Copy link
Member Author

herczyn commented Jan 29, 2026

LGTM

i assume we still wait for the vote, right?

@muscariello
Copy link
Member

@darrelmiller darrelmiller merged commit 227e249 into a2aproject:main Jan 29, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in TSC Review Jan 29, 2026
@git-vote
Copy link

git-vote bot commented Jan 29, 2026

Vote status

So far 75.00% of the users with binding vote are in favor and 0.00% are against (passing threshold: 51%).

Summary

In favor Against Abstain Not voted
6 0 0 2

Binding votes (6)

User Vote Timestamp
SivaNSAP In favor 2026-01-29 19:22:55.0 +00:00:00
ToddSegal In favor 2026-01-29 19:20:50.0 +00:00:00
darrelmiller In favor 2026-01-29 0:25:48.0 +00:00:00
geneknit In favor 2026-01-29 19:04:36.0 +00:00:00
muscariello In favor 2026-01-29 12:42:57.0 +00:00:00
spetschulatSFDC In favor 2026-01-29 19:20:21.0 +00:00:00
@hughesthe1st Pending
@000-000-000-000-000 Pending

Non-binding votes (3)

User Vote Timestamp
Tehsmash In favor 2026-01-28 9:05:01.0 +00:00:00
herczyn In favor 2026-01-28 13:48:56.0 +00:00:00
holtskinner In favor 2026-01-29 15:49:14.0 +00:00:00

@git-vote
Copy link

git-vote bot commented Jan 30, 2026

Vote closed

The vote passed! 🎉

75.00% of the users with binding vote were in favor and 0.00% were against (passing threshold: 51%).

Summary

In favor Against Abstain Not voted
6 0 0 2

Binding votes (6)

User Vote Timestamp
@SivaNSAP In favor 2026-01-29 19:22:55.0 +00:00:00
@ToddSegal In favor 2026-01-29 19:20:50.0 +00:00:00
@darrelmiller In favor 2026-01-29 0:25:48.0 +00:00:00
@geneknit In favor 2026-01-29 19:04:36.0 +00:00:00
@muscariello In favor 2026-01-29 12:42:57.0 +00:00:00
@spetschulatSFDC In favor 2026-01-29 19:20:21.0 +00:00:00

Non-binding votes (3)

User Vote Timestamp
@Tehsmash In favor 2026-01-28 9:05:01.0 +00:00:00
@herczyn In favor 2026-01-28 13:48:56.0 +00:00:00
@holtskinner In favor 2026-01-29 15:49:14.0 +00:00:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitvote/closed gitvote/passed gitvote P1 Priority for TSC Review TSC Review To be reviewed by the Technical Steering Committee

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Feat]: 1.0 Agents should be able to talk to 0.3 Agents and vice versa

4 participants