-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs(spec): Correct wording around blocking=True #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Tehsmash, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the clarity and precision of the specification regarding the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the specification to clarify the behavior of blocking=true calls. The change correctly includes interrupted states (INPUT_REQUIRED, AUTH_REQUIRED) in addition to terminal states as triggers for the operation to return. My review includes a couple of minor suggestions: one to fix a typo in a comment, and another to ensure consistency in the casing of task states in the markdown documentation, aligning it with the specified JSON serialization format.
This corrects the wording so that blocking=True includes terminal and interrupted states as triggers for returning to the client. Fixes: a2aproject#1264 Signed-off-by: Sam Betts <[email protected]>
fd3e6f8 to
069051d
Compare
muscariello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This corrects the wording so that blocking=True includes terminal and interrupted states as triggers for returning to the client.
Fixes: #1264