Skip to content

Conversation

@Tehsmash
Copy link
Contributor

This corrects the wording so that blocking=True includes terminal and interrupted states as triggers for returning to the client.

Fixes: #1264

@Tehsmash Tehsmash requested a review from a team as a code owner January 22, 2026 13:17
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Tehsmash, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the clarity and precision of the specification regarding the blocking=True parameter within the SendMessageConfiguration. It ensures that the documentation and protocol buffer definitions accurately reflect that blocking operations should return not only upon reaching a terminal state but also when specific interrupted states, such as INPUT_REQUIRED or AUTH_REQUIRED, are encountered. This change provides a more comprehensive understanding of the expected behavior for clients interacting with the system.

Highlights

  • Specification Clarity for Blocking Operations: The definition of blocking: true in SendMessageConfiguration has been updated to explicitly include INPUT_REQUIRED and AUTH_REQUIRED as "interrupted states" alongside terminal states (COMPLETED, FAILED, CANCELLED, REJECTED) that trigger a return to the client.
  • Documentation Update: The docs/specification.md file now reflects that blocking operations should return the "latest task state" instead of the "final task state" when an interrupted state is reached.
  • Protocol Buffer Definition Alignment: The comment for the blocking field in specification/grpc/a2a.proto has been updated to align with the revised specification, detailing the specific terminal and interrupted states that cause the operation to return.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the specification to clarify the behavior of blocking=true calls. The change correctly includes interrupted states (INPUT_REQUIRED, AUTH_REQUIRED) in addition to terminal states as triggers for the operation to return. My review includes a couple of minor suggestions: one to fix a typo in a comment, and another to ensure consistency in the casing of task states in the markdown documentation, aligning it with the specified JSON serialization format.

@muscariello muscariello added the P1 Priority for TSC Review label Jan 22, 2026
This corrects the wording so that blocking=True includes terminal and
interrupted states as triggers for returning to the client.

Fixes: a2aproject#1264
Signed-off-by: Sam Betts <[email protected]>
Copy link
Member

@muscariello muscariello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muscariello
Copy link
Member

@amye @darrelmiller

@holtskinner holtskinner changed the title fix(spec): Correct wording around blocking=True docs(spec): Correct wording around blocking=True Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 Priority for TSC Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Handle blocking SendMessage calls needing user interactions

3 participants