Skip to content

Conversation

@ptiper
Copy link

@ptiper ptiper commented Jan 9, 2026

Python-specific page was deleted in f74fe49

Fixes #1347

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ptiper, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a broken documentation link by updating the mkdocs.yml configuration. It removes the navigation entry for a previously deleted Python SDK page and establishes a redirect from the old Python SDK URL to the main SDK reference page, ensuring a seamless user experience for documentation access.

Highlights

  • Documentation Navigation Update: The navigation entry for the Python SDK page has been removed from the SDK Reference section in mkdocs.yml, consolidating it to point directly to the main SDK index page.
  • Broken Link Redirection: A new redirect rule has been added to mkdocs.yml to forward requests from the old sdk/python.md path to the main sdk/index.md page, preventing broken links.
  • Obsolete Redirect Removal: An outdated redirect rule for sdk/python/ to sdk/python/api/index.html has been removed from the MkDocs configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses broken links resulting from the deletion of the Python-specific SDK page. The changes in mkdocs.yml appropriately update the navigation to point 'SDK Reference' to the main SDK index page, and correctly manage redirects to prevent broken links. I have one minor suggestion to improve the long-term maintainability of the redirects configuration.

mkdocs.yml Outdated
"specification/topics/push_notifications.md": "topics/streaming-and-async.md"
"topics/index.md": "topics/what-is-a2a.md"
"topics/roadmap.md": "roadmap.md"
"sdk/python.md": "sdk/index.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

For better long-term maintainability of this growing list of redirects, consider sorting all entries in redirect_maps alphabetically by the source path (the key). This would make it easier to check for existing redirects and prevent duplicates in the future.

@ptiper ptiper changed the title docs: fix broken link to deleted Python SDK page, redirect to main SDK page docs: fix broken link to deleted Python SDK page, redirect to main SDK page. Fixes #1347 Jan 9, 2026
@ptiper
Copy link
Author

ptiper commented Jan 9, 2026

This fixes issue #1347

@ptiper ptiper marked this pull request as ready for review January 9, 2026 09:58
@ptiper ptiper requested a review from a team as a code owner January 9, 2026 09:58
@ptiper ptiper changed the title docs: fix broken link to deleted Python SDK page, redirect to main SDK page. Fixes #1347 docs: fix broken link to deleted Python SDK page, redirect to main SDK page. Jan 9, 2026
"tutorials/python/8-agent-capabilities.md": "tutorials/python/7-streaming-and-multiturn.md"
"tutorials/python/9-ollama-agent.md": "tutorials/python/7-streaming-and-multiturn.md"
"tutorials/python/10-next-steps.md": "tutorials/python/8-next-steps.md"
"sdk/python/": "sdk/python/api/index.html"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This redirect isn't currently working, which is an issue.

But the Python SDK docs are currently visible at https://a2a-protocol.org/latest/sdk/python/api/index.html

@muscariello muscariello modified the milestone: 1.0 Jan 22, 2026
@holtskinner
Copy link
Member

#1415 covers this already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: broken link to SDK Reference > Python

3 participants