Skip to content

Fix CI Failures#7

Merged
Zsailer merged 2 commits intoZsailer:extension-async-startfrom
Darshan808:fix-ci
Feb 13, 2025
Merged

Fix CI Failures#7
Zsailer merged 2 commits intoZsailer:extension-async-startfrom
Darshan808:fix-ci

Conversation

@Darshan808
Copy link
Copy Markdown

This PR fixes CI failures in JupyterLab downstream tests and test_examples.

  • test_examples: Adding a license to pyproject.toml resolves the issue.
  • JupyterLab downstream test: Followed Mike’s suggestion:

move this block back to sync start_app and document that this message banner will be shown before the async extensions are registered.

One thing I wasn't sure about—where should we document the message banner shown before async extensions are registered? And also I think we need to show some message after the async extensions are registered. Let me know your thoughts!

@krassowski
Copy link
Copy Markdown

where should we document the message banner shown before async extensions are registered

Maybe under the same section added in jupyter-server#1417 ("Starting asynchronous tasks from an extension")

@Darshan808
Copy link
Copy Markdown
Author

@Zsailer Could you approve the workflow or review the code? 😊

@Zsailer Zsailer added the bug Something isn't working label Feb 13, 2025
@Zsailer
Copy link
Copy Markdown
Owner

Zsailer commented Feb 13, 2025

Amazing work @Darshan808 and @krassowski. Thank you, folks, for jumping in here!

@Zsailer Zsailer closed this Feb 13, 2025
@Zsailer Zsailer reopened this Feb 13, 2025
@Zsailer
Copy link
Copy Markdown
Owner

Zsailer commented Feb 13, 2025

The Actions here are outdated. Let's merge this and let the tests run in the upstream PR. If we need to iterate in another PR here, that's totally fine.

@Zsailer Zsailer merged commit c076f60 into Zsailer:extension-async-start Feb 13, 2025
32 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants