fix: implement recursive dependency resolution#40
Merged
Conversation
The previous implementation of `GetLibraryDependencies` only performed a shallow scan of the binary's dependencies. This caused issues when a shared library itself had dependencies that were not directly listed in the main binary. This commit refactors `GetLibraryDependencies` to use a work queue to perform a breadth-first search of the entire dependency tree. This ensures that all transitive dependencies are discovered. A new test case, `TestRecursiveDependencies`, is added to verify the new behavior. This test is self-contained: it compiles a set of C source files with a nested dependency (`test_binary` -> `libb.so` -> `liba.so`) on the fly to ensure the recursive logic is working correctly. The test is skipped if `gcc` is not available in the environment.
|
Can confirm this works, thank you! Following is the output without and with your patch: |
thefossguy
approved these changes
Sep 7, 2025
Owner
|
Thanks guys, I'll review over the weekend! |
Zouuup
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #38 (comment), the previous implementation of
GetLibraryDependenciesonly performed a shallow scan of the binary's dependencies. This caused issues when a shared library itself had dependencies that were not directly listed in the main binary.This commit refactors
GetLibraryDependenciesto use a work queue to perform a breadth-first search of the entire dependency tree. This ensures that all transitive dependencies are discovered.A new test case,
TestRecursiveDependencies, is added to verify the new behavior. This test is self-contained: it compiles a set of C source files with a nested dependency (test_binary->libb.so->liba.so) on the fly to ensure the recursive logic is working correctly. The test is skipped ifgccis not available in the environment.