Fixed VERILATOR_ROOT variable extraction#10
Open
fadialzammar wants to merge 1 commit intoZipCPU:masterfrom
Open
Fixed VERILATOR_ROOT variable extraction#10fadialzammar wants to merge 1 commit intoZipCPU:masterfrom
fadialzammar wants to merge 1 commit intoZipCPU:masterfrom
Conversation
Owner
|
Sigh. I keep ending up going back and forth on this issue. One fix after another seems to break whatever it is I'm doing. |
Owner
|
... the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the installed version of Verilator was built in a different environment, the existing command will extract the wrong
VERILATOR_ROOTpath. For example, when using the oss-cad-suite-build,verilator -Vreturns the following:The existing command returns
/yosyshq/share/verilator, the path used when built by YosysHQ, rather than/opt/oss-cad-suite/share/verilator, the path Verilator was installed to on the current system. Using the--getenvflag instead correctly returns the second path.