Skip to content

#580: copy constructor added to be explicit as needed by C++17 and later#581

Closed
ai-mannamalai wants to merge 1 commit intoZigRazor:masterfrom
ai-mannamalai:ma-copy-ctor
Closed

#580: copy constructor added to be explicit as needed by C++17 and later#581
ai-mannamalai wants to merge 1 commit intoZigRazor:masterfrom
ai-mannamalai:ma-copy-ctor

Conversation

@ai-mannamalai
Copy link
Contributor

Fix warning for missing copy-constructor for Globals needed in partition class

  • add simple copy-ctor and not use implicit copy c-tor


Globals& operator=(const Globals& that) {
numberOfPartition = that.numberOfPartition; // number of partitions
partitionStategy = that.partitionStategy;

Check warning

Code scanning / Jshint (reported by Codacy)

Member variable 'Globals::PLACES' is not assigned a value in 'Globals::operator='. Warning

Member variable 'Globals::PLACES' is not assigned a value in 'Globals::operator='.

Globals& operator=(const Globals& that) {
numberOfPartition = that.numberOfPartition; // number of partitions
partitionStategy = that.partitionStategy;

Check warning

Code scanning / Jshint (reported by Codacy)

Member variable 'Globals::SLEEP_LIMIT' is not assigned a value in 'Globals::operator='. Warning

Member variable 'Globals::SLEEP_LIMIT' is not assigned a value in 'Globals::operator='.
@ai-mannamalai ai-mannamalai deleted the ma-copy-ctor branch February 5, 2026 19:49
@ai-mannamalai ai-mannamalai restored the ma-copy-ctor branch February 5, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant