Fixes preceding underscores and double underscores#511
Closed
JustCallMeRay wants to merge 3 commits intoZigRazor:masterfrom
Closed
Fixes preceding underscores and double underscores#511JustCallMeRay wants to merge 3 commits intoZigRazor:masterfrom
JustCallMeRay wants to merge 3 commits intoZigRazor:masterfrom
Conversation
Contributor
Author
|
I did this already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't make one (sorry, I can upon request)
The C++ standard says that anything starting with an underscore is reserved for the standard library and anything containing two underscores is reserved for the compiler. This is only in the global namespace but most of changes are
#definesso the difference is moot.This is rarely an issue but can lead to undefined behaviour being executed on compilers not tested. When it does happen it can be pain to track down.
Please see Jason Turner's video on the subject for more information