move x1 to range {q/3 , ... , 2q/3} for create_commitments#2
Open
max-zengo wants to merge 24 commits intoserde-type-namefrom
Open
move x1 to range {q/3 , ... , 2q/3} for create_commitments#2max-zengo wants to merge 24 commits intoserde-type-namefrom
max-zengo wants to merge 24 commits intoserde-type-namefrom
Conversation
leontiadZen
suggested changes
Jul 17, 2023
src/party_one.rs
Outdated
|
|
||
| while !Self::is_secret_share_in_range(&secret_share) { | ||
| secret_share = ECScalar::new_random(); | ||
| secret_share = ECScalar::from(&secret_share.to_big_int()); |
Contributor
There was a problem hiding this comment.
Can be done in one line: secret_share = ECScalar::from(&ECScalar::new_random().to_big_int());
src/party_one.rs
Outdated
|
|
||
| pub fn get_secret_share_in_range() -> FE { | ||
| let mut secret_share: FE = ECScalar::new_random(); | ||
| secret_share = ECScalar::from(&secret_share.to_big_int()); |
Contributor
There was a problem hiding this comment.
Can be done in one line: secret_share = ECScalar::from(&ECScalar::new_random().to_big_int());
src/party_one.rs
Outdated
| let secret_share: FE = | ||
| ECScalar::from(&secret_share.to_big_int().div_floor(&BigInt::from(3))); | ||
| //in Lindell's protocol range proof works only for x1 \in {q/3 , ... , 2q/3} | ||
| pub fn is_secret_share_in_range(secret_share: &FE) -> bool { |
Contributor
There was a problem hiding this comment.
can you have a look in sample_range in curv and adapt your code, seems that is what we want
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change is following the update in Lindell'17 paper in the first message of P1