chore: Remove npm i stage from action#26
Merged
thelukewalton merged 5 commits intomainfrom Apr 4, 2025
Merged
Conversation
… package manager they want i.e. yarn
Contributor
PR Checks Complete✅ Analysis✅ Formatting✅ Testing |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the npm install stage from both the GitHub action and the related code, allowing users to choose their preferred package manager. Key changes include the removal of the npm installation parameter and related code in src/scripts/comment.ts and src/main.ts, and updating the workflow documentation in README.md.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/scripts/comment.ts | Removed the npm installation parameter and its usage; added an explicit type for comment. |
| src/main.ts | Removed the npm install command call, aligning with the removal of the npm installation stage. |
| README.md | Updated the workflow to use "npm ci" for dependencies, but may need adjustment for alternative package managers. |
Comments suppressed due to low confidence (1)
src/scripts/comment.ts:108
- [nitpick] Using 'any' for the comment parameter may reduce type safety; consider defining a more specific type if one is available.
const comment = comments.find((comment: any) =>
DE7924
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to use whatever package manager they want i.e. yarn
ci: Update PR script
deps: Update npm dependencies