Skip to content

WIP: Implement COCKTAIL-DKG#1032

Draft
conradoplg wants to merge 29 commits intomainfrom
cocktail-dkg
Draft

WIP: Implement COCKTAIL-DKG#1032
conradoplg wants to merge 29 commits intomainfrom
cocktail-dkg

Conversation

@conradoplg
Copy link
Copy Markdown
Contributor

This is an implementation of the COCKTAIL-DKG protocol as specified in this PR (test vectors).

While doing this I gathered feedback which was posted in C2SP.

This is blocked on that feedback being considered.

We should also eventually add more thorough testing.

In this PR I experimented with using Claude Code. The base implementation was done by it and some of the adjustments/refactors too. It did a pretty decent job but got some very straightforward things wrong (e.g. not using xaes-gcm where needed). I reviewed everything. I tried to preserve the history in the commits (each prompt generated a separate commit, but some of the commits were done manually; I didn't explicitly indicated which is which)

h6: &[u8],
) -> Result<([u8; 32], [u8; 24]), Error<C>> {
let mut key = [0u8; 32];
let mut nonce = [0u8; 24];

Check failure

Code scanning / CodeQL

Hard-coded cryptographic value Critical

This hard-coded value is used as
a nonce
.
This hard-coded value is used as
a nonce
.
This hard-coded value is used as
a nonce
.

Copilot Autofix

AI 17 days ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants