Draft
Conversation
…atible with gencode
| h6: &[u8], | ||
| ) -> Result<([u8; 32], [u8; 24]), Error<C>> { | ||
| let mut key = [0u8; 32]; | ||
| let mut nonce = [0u8; 24]; |
Check failure
Code scanning / CodeQL
Hard-coded cryptographic value Critical
Copilot Autofix
AI 17 days ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of the COCKTAIL-DKG protocol as specified in this PR (test vectors).
While doing this I gathered feedback which was posted in C2SP.
This is blocked on that feedback being considered.
We should also eventually add more thorough testing.
In this PR I experimented with using Claude Code. The base implementation was done by it and some of the adjustments/refactors too. It did a pretty decent job but got some very straightforward things wrong (e.g. not using xaes-gcm where needed). I reviewed everything. I tried to preserve the history in the commits (each prompt generated a separate commit, but some of the commits were done manually; I didn't explicitly indicated which is which)