fix(overlay): buildAnimationNode wrapper + nested target (ADR 011 I7)#23
Merged
Conversation
Align the Solar oracle twin with Orion's I7 geometry fix: the general animation.play node is a transform WRAPPER dimensioned to the target overlay (props = its x/y/width/height), with the target NESTED beneath (children) so it inherits the animated transform/opacity. NOT a full-screen aplat — translating/fading a 1920×1080 uniform fill is invisible (the live I7 crimson-aplat bug). props/children are optional and default to the full-screen self-painting cover (the degenerate wipe-cover node), so the wipe-cover byte-parity and the existing oracle cases stay byte-identical. Adds a wrapper+nested-child test pinning the new shape against Orion's Go parity twin. Refs ADR 011 (I7) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Oracle twin of Orion's I7 geometry fix (ZabLaboratory/Orion#167). The general
animation.playnode was a full-screen aplat — translating/fading a 1920×1080 uniform fill is invisible (the live crimson-aplat bug).What
buildAnimationNodenow acceptsprops(the target overlay'sx/y/width/height— the wrapper is dimensioned to the overlay) andchildren(the nested target, which inherits the animatedtransform/opacity).Both are optional and default to the full-screen self-painting cover, so the degenerate wipe-cover node and the existing oracle cases stay byte-identical (the Go↔TS parity invariant holds;
buildWipeCoverNodeis unchanged).Tests (run locally, green)
npm run typecheckclean,npm run lintclean (max-warnings 0),npm test35 passed,npm run buildok (bundle budget ok).animation-node.test.tscase pins the wrapper+nested-child shape (transform wrapper sized to target, no background, target nested) against Orion's Go parity twin; the 3 existing cases (full-screen default, key override, wipe-cover subsumption) stay green.Refs ADR 011 (I7). Companion: Orion PR #167 — must merge in lock-step (parity).
🤖 Generated with Claude Code