[BUGFIX] Do not preview website title if config.showWebsiteTitle is false

[Mabahe]

Test instructions

This PR can be tested by following these steps:

• Set Typoscipt config.showWebsiteTitle = 0 and have a website title configured in the site you still see the title in the preview sometimes

Quality assurance

• I have tested this code to the best of my abilities
• I have added unittests to verify the code works as intended

Fixes #654

[RinyVT]

Hi @Mabahe,

Thanks for the PR! Something that was missed during the 12 upgrade I see.
One thing, is there are particular reason you've also removed the $GLOBALS['TSFE']->tmpl->setup['sitetitle'] line?

Although sitetitle was from typoscript records which is not something that's in core anymore, technically when someone sets it directly in their typoscript setup it would still work and removing this line would be breaking.

Is it okay if I restore that line (with a todo comment) or did this line also produce a bug?

[Mabahe]

Hi @RinyVT,

you can access $GLOBALS['TSFE']->tmpl only < v13 and fetching the sitetitle from typoscript was
deprecated in TYPO3 version 10 and removed in version 11 (see my commit message), so that hasn't been working for ages.

[Mabahe]

Here is the position in v10 core
https://github.com/TYPO3/typo3/blob/10.4/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php#L3021

[RinyVT]

Good point, although it would technically be a breaking change (if someone has set sitetitle manually on the root typoscript setup this would break) I consider it a bugfix as it is indeed old functionality.
Thanks for the PR, will merge it now!