Add vocal samples for several menus - #1219
Open
W-Livi wants to merge 3 commits into
Open
Conversation
Title blurb plays only once per session. I wanted to have it wait for the closure of the anti-piracy popup (if applicable), but couldn't quite work out how to do that nicely. Music Library blurb should play every time when (re)entering the library, either from main menu or from gameplay. I didn't want the Profiles blurb playing again when exiting from keybindings, so I have the Main Menu handling the Profiles and Settings blurbs.
wyrdough
reviewed
Nov 17, 2025
wyrdough
left a comment
wyrdough
left a comment
Contributor
There was a problem hiding this comment.
Don't take the suggestions as perfect gospel, I banged them out from memory in GitHub's terrible review interface, lol.
I haven't tested it yet, but the code here seems perfectly cromulent.
Incorporated wyrdough's feedback, and tested briefly to make sure it works. Also moved the LoadingScreen await to live inside of the `if (!_blurbPlayed)` block, to avoid unnecessary awaits on future visits to the main menu. Co-Authored-By: wyrdough <680744+wyrdough@users.noreply.github.com>
Contributor
Author
|
Thank you for the feedback; I have incorporated your suggestions :) |
wyrdough
approved these changes
Nov 19, 2025
wyrdough
left a comment
wyrdough
left a comment
Contributor
There was a problem hiding this comment.
need to test this for myself, but I'm happy with the code
github-actions
Bot
added
the
Has Conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following screens/dialogs now have an associated vocal sample:
the samples provided are my own recordings, with some light reverb applied.
(an accompanying YARG.Core PR has also been made, required for the scripts herein to call the new samples.)