[NDGL-65] NDGLNavigationBar의 Trailing 아이콘이 없을 때 타이틀이 중앙에 정렬되지 않는 이슈 수정#14
Merged
[NDGL-65] NDGLNavigationBar의 Trailing 아이콘이 없을 때 타이틀이 중앙에 정렬되지 않는 이슈 수정#14
Conversation
WalkthroughNDGLNavigationBar의 레이아웃 패딩, 아이콘 모디파이어와 틴트, 트레일링 콘텐츠 처리 로직이 변경되었고, 관련 프리뷰가 추가되었습니다. .claude 설정 파일에서 permissions 블록이 제거되었습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@core/ui/src/main/java/com/yapp/ndgl/core/ui/designsystem/NDGLNavigationBar.kt`:
- Around line 89-94: The icon's Modifier chain in NDGLNavigationBar.kt currently
uses .size(40.dp).padding(6.dp) which results in a 52dp visual size and
mismatches the 40dp placeholder and 48dp Row height; update the modifier on the
icon (the chain that includes clip(CircleShape), clickable(onClick = onClick),
size(40.dp), padding(6.dp)) so the padding comes before size (i.e.,
.padding(6.dp).size(40.dp)) to keep the visible element 40dp while preserving a
larger touch target, or alternatively adjust the placeholder/Row dimensions to
52dp to match the current ordering—pick one approach and apply it consistently
to the icon modifier and related placeholder sizing in NDGLNavigationBar.
2b9e68f to
9b69980
Compare
9b69980 to
7a44cc4
Compare
7a44cc4 to
e477480
Compare
Member
Author
|
클로드 로컬 설정 파일이 깃에 올라가 있어서 제거하고 gitignore 파일에 추가했습니다 |
Contributor
감사합니다!! |
mj010504
approved these changes
Feb 4, 2026
Contributor
|
수고하셨습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NDGLNavigationBar의 Trailing 아이콘이 없을 때 타이틀이 중앙에 정렬되지 않는 이슈 수정
클로드 로컬 설정 파일 제거 및 .gitignore 추가
연관 문서
디자인
변경사항
Summary by CodeRabbit